[coreboot-gerrit] Patch merged into coreboot/master: 0b2ee93 pnp: Remove now plain wrappers for default PnP functions

gerrit at coreboot.org gerrit at coreboot.org
Mon Jun 17 21:42:28 CEST 2013


the following patch was just integrated into master:
commit 0b2ee9391079a5092eb99dce764e3836eeb92cd9
Author: Nico Huber <nico.h at gmx.de>
Date:   Sat Jun 15 19:58:35 2013 +0200

    pnp: Remove now plain wrappers for default PnP functions
    
    After removing the enter()/exit() functions for configuration mode,
    most wrappers for our standard PnP functions just call the underlying
    default implementation.
    
    Remove those with a little cocci:
        @ op_match @
        identifier op;
        identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$";
        type device_t;
        identifier dev;
        @@
         static void op(device_t dev) { pnp_op(dev); }
    
        @@
        identifier op_match.op;
        @@
        -op(...) {...}
    
        /* Three rules to match the alignment, hmmp... */
        @@
        identifier op_match.op, op_match.pnp_op;
        identifier ops;
        @@
         struct device_operations ops = {
        -        .set_resources    = op,
        +        .set_resources    = pnp_op,
         };
    
        @@
        identifier op_match.op, op_match.pnp_op;
        identifier ops;
        @@
         struct device_operations ops = {
        -        .enable_resources = op,
        +        .enable_resources = pnp_op,
         };
    
        @@
        identifier op_match.op, op_match.pnp_op;
        identifier ops;
        @@
         struct device_operations ops = {
        -        .enable           = op,
        +        .enable           = pnp_op,
         };
    
    Change-Id: Idc0e52c7e3600a01f3b6a4e17763557b271b481e
    Signed-off-by: Nico Huber <nico.h at gmx.de>
    Reviewed-on: http://review.coreboot.org/3483
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3483 for details.

-gerrit



More information about the coreboot-gerrit mailing list