[coreboot-gerrit] Patch merged into coreboot/master: 482af6d libpayload: Redirect USB slave init through controller driver

gerrit at coreboot.org gerrit at coreboot.org
Thu Jun 13 22:16:28 CEST 2013


the following patch was just integrated into master:
commit 482af6d15ca8eed28b51edc11692815419326d65
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Fri May 24 15:48:56 2013 +0200

    libpayload: Redirect USB slave init through controller driver
    
    xHCI requires special treatment of set_address since it determines
    the device number itself (instead of the driver, as with the other
    controllers). The controller also wants to validate a chosen device
    configuration and we need to setup additional structures for the
    device and the endpoints.
    
    Therefore, we add three functions to the hci_t structure, namely:
      set_address()
      finish_device_config()
      destroy_device()
    Current implementation for the Set Address request moved into
    generic_set_address() which is set_address() for the UHCI, OCHI and
    EHCI drivers. The latter two are only provided as hooks for the xHCI
    driver.
    
    The Set Configuration request is moved after endpoint enumeration.
    For all other controller drivers nothing changes, as there is no other
    device communication between the lines where the set_configuration()
    call moved.
    
    Change-Id: I6127627b9367ef573aa1a1525782bc1304ea350d
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
    Reviewed-on: http://review.coreboot.org/3447
    Tested-by: build bot (Jenkins)
    Reviewed-by: Anton Kochkov <anton.kochkov at gmail.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3447 for details.

-gerrit



More information about the coreboot-gerrit mailing list