[coreboot-gerrit] Patch merged into coreboot/master: 6c4f3ce AMD S3 resume: use a function to replace duplicated code

gerrit at coreboot.org gerrit at coreboot.org
Thu Jun 13 01:17:23 CEST 2013


the following patch was just integrated into master:
commit 6c4f3ce4906c32e365825a7d8630945f79b60616
Author: Siyuan Wang <wangsiyuanbuaa at gmail.com>
Date:   Fri Jun 7 14:31:19 2013 +0800

    AMD S3 resume: use a function to replace duplicated code
    
    In function OemAgesaSaveMtrr of 'src/cpu/amd/agesa/s3_resume.c',
    there are many code like this:
      msr_data = rdmsr(0x258);
      flash->write(flash, nvram_pos, 4, &msr_data.lo);
      nvram_pos += 4;
      flash->write(flash, nvram_pos, 4, &msr_data.hi);
      nvram_pos += 4;
    Add a function write_mtrr to do this.
    
    Change-Id: Id6464e637db1758b07ac2d79d3be1375a8d49651
    Signed-off-by: Siyuan Wang <SiYuan.Wang at amd.com>
    Signed-off-by: Siyuan Wang <wangsiyuanbuaa at gmail.com>
    Reviewed-on: http://review.coreboot.org/3410
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3410 for details.

-gerrit



More information about the coreboot-gerrit mailing list