[coreboot-gerrit] New patch to review for coreboot: 5021dbb Fix dump of ALT_GP_SMI_STS register in intel southbridges
Aladyshev Konstantin (aladyshev22@gmail.com)
gerrit at coreboot.org
Tue Jun 11 22:49:08 CEST 2013
Aladyshev Konstantin (aladyshev22 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3436
-gerrit
commit 5021dbb6e6bad23c2d86fcb05f8e4c271211c68a
Author: Konstantin Aladyshev <aladyshev at nicevt.ru>
Date: Thu Mar 7 04:37:02 2013 +0400
Fix dump of ALT_GP_SMI_STS register in intel southbridges
Mapping is as follows: bit 15 corresponds to GPIO15 ... bit 0 corresponds to
GPIO0.
Change-Id: I661ce56d9373887270ba3c0518892fbbe6d9de7c
Signed-off-by: Konstantin Aladyshev <aladyshev at nicevt.ru>
---
src/southbridge/intel/bd82x6x/smi.c | 2 +-
src/southbridge/intel/i82801dx/smi.c | 2 +-
src/southbridge/intel/i82801gx/smi.c | 2 +-
src/southbridge/intel/i82801ix/smi.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/southbridge/intel/bd82x6x/smi.c b/src/southbridge/intel/bd82x6x/smi.c
index b696994..0166edf 100644
--- a/src/southbridge/intel/bd82x6x/smi.c
+++ b/src/southbridge/intel/bd82x6x/smi.c
@@ -173,7 +173,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i>= 0; i--) {
- if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
+ if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", i);
}
printk(BIOS_DEBUG, "\n");
}
diff --git a/src/southbridge/intel/i82801dx/smi.c b/src/southbridge/intel/i82801dx/smi.c
index fcf36e1..d2e3e25 100644
--- a/src/southbridge/intel/i82801dx/smi.c
+++ b/src/southbridge/intel/i82801dx/smi.c
@@ -177,7 +177,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i>= 0; i--) {
- if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
+ if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", i);
}
printk(BIOS_DEBUG, "\n");
}
diff --git a/src/southbridge/intel/i82801gx/smi.c b/src/southbridge/intel/i82801gx/smi.c
index fec0602..8cb11b2 100644
--- a/src/southbridge/intel/i82801gx/smi.c
+++ b/src/southbridge/intel/i82801gx/smi.c
@@ -177,7 +177,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i>= 0; i--) {
- if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
+ if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", i);
}
printk(BIOS_DEBUG, "\n");
}
diff --git a/src/southbridge/intel/i82801ix/smi.c b/src/southbridge/intel/i82801ix/smi.c
index 10c31b1..de9931c 100644
--- a/src/southbridge/intel/i82801ix/smi.c
+++ b/src/southbridge/intel/i82801ix/smi.c
@@ -182,7 +182,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i>= 0; i--) {
- if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
+ if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", i);
}
printk(BIOS_DEBUG, "\n");
}
More information about the coreboot-gerrit
mailing list