[coreboot-gerrit] Patch set updated for coreboot: f4cbc47 intel/lynxpoint/Makefile.inc: Add `usb_debug.c` to fix build error

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Jun 11 10:00:57 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3426


commit f4cbc47683e06c90687d2fb82dc5233c539f7fba
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Jun 10 10:37:58 2013 +0200

    intel/lynxpoint/Makefile.inc: Add `usb_debug.c` to fix build error
    Building the board Intel White Tip Mountain which has the Intel
    Lynx Point platform controller hub (PCH) and enabling the USB
    debug console, the build fails with the following error.
        $ LANG=C make
            CC         vendorcode/google/chromeos/fmap.smm.o
        build/cpu/x86/smm/smm.o: In function `usbdebug_init':
        /src/coreboot/src/lib/usbdebug.c:559: undefined reference to `set_debug_port'
        /src/coreboot/src/lib/usbdebug.c:564: undefined reference to `set_debug_port'
        make: *** [build/cpu/x86/smm/smm.elf] Error 1
    Adding `usb_debug.c` to the build, so it is available when building
    ramstage and SMM, fixes this error, though building Intel White Tip
    Mountain succeeds only with the next commit.
    Change-Id: If52eef38935dd52a8598c8272e5a03c748556fb3
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/southbridge/intel/lynxpoint/Makefile.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/southbridge/intel/lynxpoint/Makefile.inc b/src/southbridge/intel/lynxpoint/Makefile.inc
index 7d1f894..f8a4c03 100644
--- a/src/southbridge/intel/lynxpoint/Makefile.inc
+++ b/src/southbridge/intel/lynxpoint/Makefile.inc
@@ -51,6 +51,8 @@ smm-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
 romstage-y += early_usb.c early_smbus.c early_me.c me_status.c early_pch.c
 romstage-$(CONFIG_USBDEBUG) += usb_debug.c
+ramstage-$(CONFIG_USBDEBUG) += usb_debug.c
+smm-$(CONFIG_USBDEBUG) += usb_debug.c
 romstage-y += reset.c early_spi.c rcba.c

More information about the coreboot-gerrit mailing list