[coreboot-gerrit] New patch to review for coreboot: 85e3856 AMD Southbridge CS5536: make use of #include <device/smbus_def.h>

Christian Gmeiner (christian.gmeiner@gmail.com) gerrit at coreboot.org
Wed Jun 5 17:02:38 CEST 2013


Christian Gmeiner (christian.gmeiner at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3376

-gerrit

commit 85e38566b0fc3345d39d9cb78ab3ee4c9af76a7a
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date:   Wed Jun 5 16:40:34 2013 +0200

    AMD Southbridge CS5536: make use of #include <device/smbus_def.h>
    
    Change-Id: Ia2dff49d3e2b086546785d992f2d92bcf4d1ef1c
    Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
---
 src/southbridge/amd/cs5536/smbus.c | 3 ---
 src/southbridge/amd/cs5536/smbus.h | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/southbridge/amd/cs5536/smbus.c b/src/southbridge/amd/cs5536/smbus.c
index f6b187e..5373824 100644
--- a/src/southbridge/amd/cs5536/smbus.c
+++ b/src/southbridge/amd/cs5536/smbus.c
@@ -22,9 +22,6 @@
 #include "cs5536.h"
 #include "smbus.h"
 
-#define SMBUS_ERROR -1
-#define SMBUS_WAIT_UNTIL_READY_TIMEOUT -2
-#define SMBUS_WAIT_UNTIL_DONE_TIMEOUT  -3
 #define SMBUS_TIMEOUT (1000)
 
 static void smbus_delay(void)
diff --git a/src/southbridge/amd/cs5536/smbus.h b/src/southbridge/amd/cs5536/smbus.h
index cbfa7b2..0dd2fc5 100644
--- a/src/southbridge/amd/cs5536/smbus.h
+++ b/src/southbridge/amd/cs5536/smbus.h
@@ -20,6 +20,8 @@
 #ifndef _CS5536_SMBUS_H
 #define _CS5536_SMBUS_H
 
+#include <device/smbus_def.h>
+
 int smbus_start_condition(unsigned smbus_io_base);
 int smbus_stop_condition(unsigned smbus_io_base);
 int smbus_check_stop_condition(unsigned smbus_io_base);



More information about the coreboot-gerrit mailing list