[coreboot-gerrit] Patch merged into coreboot/master: 9c50e6a Intel BD82x6x: LPC: Unify I/O APIC setup

gerrit at coreboot.org gerrit at coreboot.org
Mon Jun 3 08:21:54 CEST 2013

the following patch was just integrated into master:
commit 9c50e6a4a071a03c4dedd8eb87022644e9ee74c3
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri May 3 12:23:39 2013 +0200

    Intel BD82x6x: LPC: Unify I/O APIC setup
    Remove local copies of reading and writing I/O APIC registers by
    using already available functions.
    This change is similar to
        commit db4f875a412e6c41f48a86a79b72465f6cd81635
        Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
        Date:   Tue Jan 31 17:24:12 2012 +0200
            IOAPIC: Divide setup_ioapic() in two parts.
            Reviewed-on: http://review.coreboot.org/300
        commit e614353194c712a40aa8444a530b2062876eabe3
        Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
        Date:   Tue Feb 26 17:24:41 2013 +0200
            Unify setting 82801a/b/c/d IOAPIC ID
            Reviewed-on: http://review.coreboot.org/2532
    and uses `io_apic_read()` and `io_apic_write()` too. Define
    `ACPI_EN` in the header file `pch.h`.
    As commented by Aaron Durbin, a separate `pch_enable_acpi()` is
    not needed: “The existing code path *in this file* is about enabling
    the io apic.” [1].
    [1] http://review.coreboot.org/#/c/3182/4/src/southbridge/intel/lynxpoint/lpc.c
    Change-Id: I4478b1902d09061ca1db8eab6b71fef388c7a74c
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3183
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at google.com>

See http://review.coreboot.org/3183 for details.


More information about the coreboot-gerrit mailing list