[coreboot-gerrit] New patch to review for coreboot: 849a8e5 AMD Olive Hill: Update ACPI routing & devicetree.cb

Bruce Griffith (Bruce.Griffith@se-eng.com) gerrit at coreboot.org
Fri Jul 26 12:33:48 CEST 2013


Bruce Griffith (Bruce.Griffith at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3817

-gerrit

commit 849a8e50270223185986433484064d5665f8c49e
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Wed Mar 27 11:10:26 2013 -0600

    AMD Olive Hill: Update ACPI routing & devicetree.cb
    
    Update the ACPI DSDT.asl and routing.asl files to just include the
    devices on kabini.  Update comments and copyright dates.
    
    Update the devicetree.cb file to just include hardware on the
    kabini chip.
    
    Change-Id: I83f7221c7b3b7aec3678db1fc33c0987477a3d71
    Reviewed-by: Steven Sherk <steven.sherk at se-eng.com>
    Reviewed-by: Kimarie Hoot <kimarie.hoot at se-eng.com>
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/mainboard/amd/olivehill/acpi/routing.asl | 198 +++------------------------
 src/mainboard/amd/olivehill/devicetree.cb    |   9 +-
 src/mainboard/amd/olivehill/dsdt.asl         | 138 +++++++------------
 3 files changed, 79 insertions(+), 266 deletions(-)

diff --git a/src/mainboard/amd/olivehill/acpi/routing.asl b/src/mainboard/amd/olivehill/acpi/routing.asl
index 1d54c0f..4ce45c9 100644
--- a/src/mainboard/amd/olivehill/acpi/routing.asl
+++ b/src/mainboard/amd/olivehill/acpi/routing.asl
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2012 Advanced Micro Devices, Inc.
+ * Copyright (C) 2013 Advanced Micro Devices, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -29,58 +29,29 @@ DefinitionBlock ("DSDT.AML","DSDT",0x01,"XXXXXX","XXXXXXXX",0x00010001
 Scope(\_SB) {
 	Name(PR0, Package(){
 		/* NB devices */
-		/* Bus 0, Dev 0 - F15 Host Controller */
+		/* Bus 0, Dev 0 - F16 Host Controller */
+
 		/* Bus 0, Dev 1 - PCI Bridge for Internal Graphics(IGP) */
+		/* Bus 0, Dev 1, Func 1 - HDMI Audio Controller */
 		Package(){0x0001FFFF, 0, INTB, 0 },
 		Package(){0x0001FFFF, 1, INTC, 0 },
 
-		/* Bus 0, Dev 2 - PCIe Bridge for x8 PCIe Slot (GFX0) */
+
+		/* Bus 0, Dev 2 Func 0,1,2,3,4,5 - PCIe Bridges */
 		Package(){0x0002FFFF, 0, INTC, 0 },
 		Package(){0x0002FFFF, 1, INTD, 0 },
 		Package(){0x0002FFFF, 2, INTA, 0 },
 		Package(){0x0002FFFF, 3, INTB, 0 },
 
-		/* Bus 0, Dev 3 - PCIe graphics port 1 bridge */
-		Package(){0x0003FFFF, 0, INTD, 0 },
-		Package(){0x0003FFFF, 1, INTA, 0 },
-		Package(){0x0003FFFF, 2, INTB, 0 },
-		Package(){0x0003FFFF, 3, INTC, 0 },
-
-		/* Bus 0, Dev 4 - PCIe Bridge for Express Card Slot */
-		Package(){0x0004FFFF, 0, INTA, 0 },
-		Package(){0x0004FFFF, 1, INTB, 0 },
-		Package(){0x0004FFFF, 2, INTC, 0 },
-		Package(){0x0004FFFF, 3, INTD, 0 },
-
-		/* Bus 0, Dev 5 - General purpose PCIe bridge 5 */
-		Package(){0x0005FFFF, 0, INTB, 0 },
-		Package(){0x0005FFFF, 1, INTC, 0 },
-		Package(){0x0005FFFF, 2, INTD, 0 },
-		Package(){0x0005FFFF, 3, INTA, 0 },
-
-		/* Bus 0, Dev 6 - PCIe Bridge for Ethernet Chip */
-		Package(){0x0006FFFF, 0, INTC, 0 },
-		Package(){0x0006FFFF, 1, INTD, 0 },
-		Package(){0x0006FFFF, 2, INTA, 0 },
-		Package(){0x0006FFFF, 3, INTB, 0 },
-
-		/* Bus 0, Dev 7 - PCIe Bridge for x1 PCIe Slot */
-		Package(){0x0007FFFF, 0, INTD, 0 },
-		Package(){0x0007FFFF, 1, INTA, 0 },
-		Package(){0x0007FFFF, 2, INTB, 0 },
-		Package(){0x0007FFFF, 3, INTC, 0 },
-
-		/* Bus 0, Funct 8 - Southbridge port (normally hidden) */
-
-		/* SB devices */
-		/* Bus 0, Dev 20 - F0:SMBus/ACPI,F1:IDE;F2:HDAudio;F3:LPC;F4:PCIBridge;F5:USB */
+		/* FCH devices */
+		/* Bus 0, Dev 20 - F0:SMBus/ACPI,F2:HDAudio;F3:LPC;F7:SD */
 		Package(){0x0014FFFF, 0, INTA, 0 },
 		Package(){0x0014FFFF, 1, INTB, 0 },
 		Package(){0x0014FFFF, 2, INTC, 0 },
 		Package(){0x0014FFFF, 3, INTD, 0 },
 
-		/* Bus 0, Dev 19 - USB: OHCI, dev 18,19 func 0-2, dev 20 func 5;
-		 * EHCI, dev 18, 19 func 2 */
+		/* Bus 0, Dev 18, 19, 22 Func 0 - USB: OHCI */
+		/* Bus 0, Dev 18, 19, 22 Func 1 - USB: EHCI */
 		Package(){0x0012FFFF, 0, INTC, 0 },
 		Package(){0x0012FFFF, 1, INTB, 0 },
 
@@ -97,11 +68,6 @@ Scope(\_SB) {
 		/* Bus 0, Dev 17 - SATA controller */
 		Package(){0x0011FFFF, 0, INTD, 0 },
 
-		/* Bus 0, Dev 21 Pcie Bridge */
-		Package(){0x0015FFFF, 0, INTA, 0 },
-		Package(){0x0015FFFF, 1, INTB, 0 },
-		Package(){0x0015FFFF, 2, INTC, 0 },
-		Package(){0x0015FFFF, 3, INTD, 0 },
 	})
 
 	Name(APR0, Package(){
@@ -112,53 +78,22 @@ Scope(\_SB) {
 		Package(){0x0001FFFF, 0, 0, 17 },
 		Package(){0x0001FFFF, 1, 0, 18 },
 
-		/* Bus 0, Dev 2 - PCIe Bridge for x8 PCIe Slot (GFX0) */
+		/* Bus 0, Dev 2 - PCIe Bridges  */
 		Package(){0x0002FFFF, 0, 0, 18 },
 		Package(){0x0002FFFF, 1, 0, 19 },
 		Package(){0x0002FFFF, 2, 0, 16 },
 		Package(){0x0002FFFF, 3, 0, 17 },
 
-		/* Bus 0, Dev 3 - PCIe graphics port 1 bridge */
-		Package(){0x0003FFFF, 0, 0, 19 },
-		Package(){0x0003FFFF, 1, 0, 16 },
-		Package(){0x0003FFFF, 2, 0, 17 },
-		Package(){0x0003FFFF, 3, 0, 18 },
-
-		/* Bus 0, Dev 4 - PCIe Bridge for Express Card Slot */
-		Package(){0x0004FFFF, 0, 0, 16 },
-		Package(){0x0004FFFF, 1, 0, 17 },
-		Package(){0x0004FFFF, 2, 0, 18 },
-		Package(){0x0004FFFF, 3, 0, 19 },
-
-		/* Bus 0, Dev 5 - General purpose PCIe bridge 5 */
-		Package(){0x0005FFFF, 0, 0, 17 },
-		Package(){0x0005FFFF, 1, 0, 18 },
-		Package(){0x0005FFFF, 2, 0, 19 },
-		Package(){0x0005FFFF, 3, 0, 16 },
-
-		/* Bus 0, Dev 6 - General purpose PCIe bridge 6 */
-		Package(){0x0006FFFF, 0, 0, 18 },
-		Package(){0x0006FFFF, 1, 0, 19 },
-		Package(){0x0006FFFF, 2, 0, 16 },
-		Package(){0x0006FFFF, 3, 0, 17 },
-
-		/* Bus 0, Dev 7 - PCIe Bridge for network card */
-		Package(){0x0007FFFF, 0, 0, 19 },
-		Package(){0x0007FFFF, 1, 0, 16 },
-		Package(){0x0007FFFF, 2, 0, 17 },
-		Package(){0x0007FFFF, 3, 0, 18 },
-
-		/* Bus 0, Funct 8 - Southbridge port (normally hidden) */
 
 		/* SB devices in APIC mode */
-		/* Bus 0, Dev 20 - F0:SMBus/ACPI, F1:IDE; F2:HDAudio; F3:LPC; F4:PCIBridge; F5:USB */
+		/* Bus 0, Dev 20 - F0:SMBus/ACPI,F2:HDAudio;F3:LPC;F7:SD */
 		Package(){0x0014FFFF, 0, 0, 16 },
 		Package(){0x0014FFFF, 1, 0, 17 },
 		Package(){0x0014FFFF, 2, 0, 18 },
 		Package(){0x0014FFFF, 3, 0, 19 },
 
-		/* Bus 0, Dev 19 - USB: OHCI, dev 18,19 func 0-2, dev 20 func 5;
-		 * EHCI, dev 18, 19 func 2 */
+		/* Bus 0, Dev 18, 19, 22 Func 0 - USB: OHCI */
+		/* Bus 0, Dev 18, 19, 22 Func 1 - USB: EHCI */
 		Package(){0x0012FFFF, 0, 0, 18 },
 		Package(){0x0012FFFF, 1, 0, 17 },
 
@@ -175,47 +110,23 @@ Scope(\_SB) {
 		/* Bus 0, Dev 17 - SATA controller */
 		Package(){0x0011FFFF, 0, 0, 19 },
 
-		/* Bus0, Dev 21 PCIE Bridge */
-		Package(){0x0015FFFF, 0, 0, 16 },
-		Package(){0x0015FFFF, 1, 0, 17 },
-		Package(){0x0015FFFF, 2, 0, 18 },
-		Package(){0x0015FFFF, 3, 0, 19 },
 	})
 
 	Name(PS2, Package(){
-		/* The external GFX - Hooked to PCIe slot 2 */
 		Package(){0x0000FFFF, 0, INTC, 0 },
 		Package(){0x0000FFFF, 1, INTD, 0 },
 		Package(){0x0000FFFF, 2, INTA, 0 },
 		Package(){0x0000FFFF, 3, INTB, 0 },
 	})
 	Name(APS2, Package(){
-		/* The external GFX - Hooked to PCIe slot 2 */
 		Package(){0x0000FFFF, 0, 0, 18 },
 		Package(){0x0000FFFF, 1, 0, 19 },
 		Package(){0x0000FFFF, 2, 0, 16 },
 		Package(){0x0000FFFF, 3, 0, 17 },
 	})
 
-#if 1
-	Name(PS3, Package(){
-		/* The external GFX - Hooked to PCIe slot 3 */
-		Package(){0x0000FFFF, 0, INTD, 0 },
-		Package(){0x0000FFFF, 1, INTA, 0 },
-		Package(){0x0000FFFF, 2, INTB, 0 },
-		Package(){0x0000FFFF, 3, INTC, 0 },
-	})
-	Name(APS3, Package(){
-		/* The external GFX - Hooked to PCIe slot 3 */
-		Package(){0x0000FFFF, 0, 0, 19 },
-		Package(){0x0000FFFF, 1, 0, 16 },
-		Package(){0x0000FFFF, 2, 0, 17 },
-		Package(){0x0000FFFF, 3, 0, 18 },
-	})
-#endif
-
+	/* GFX */
 	Name(PS4, Package(){
-		/* PCIe slot - Hooked to PCIe slot 4 */
 		Package(){0x0000FFFF, 0, INTA, 0 },
 		Package(){0x0000FFFF, 1, INTB, 0 },
 		Package(){0x0000FFFF, 2, INTC, 0 },
@@ -229,128 +140,61 @@ Scope(\_SB) {
 		Package(){0x0000FFFF, 3, 0, 19 },
 	})
 
+	/* GPP 0 */
 	Name(PS5, Package(){
-		/* PCIe slot - Hooked to PCIe slot 5 */
 		Package(){0x0000FFFF, 0, INTB, 0 },
 		Package(){0x0000FFFF, 1, INTC, 0 },
 		Package(){0x0000FFFF, 2, INTD, 0 },
 		Package(){0x0000FFFF, 3, INTA, 0 },
 	})
 	Name(APS5, Package(){
-		/* PCIe slot - Hooked to PCIe slot 5 */
 		Package(){0x0000FFFF, 0, 0, 17 },
 		Package(){0x0000FFFF, 1, 0, 18 },
 		Package(){0x0000FFFF, 2, 0, 19 },
 		Package(){0x0000FFFF, 3, 0, 16 },
 	})
 
+	/* GPP 1 */
 	Name(PS6, Package(){
-		/* PCIe slot - Hooked to PCIe slot 6 */
 		Package(){0x0000FFFF, 0, INTC, 0 },
 		Package(){0x0000FFFF, 1, INTD, 0 },
 		Package(){0x0000FFFF, 2, INTA, 0 },
 		Package(){0x0000FFFF, 3, INTB, 0 },
 	})
 	Name(APS6, Package(){
-		/* PCIe slot - Hooked to PCIe slot 6 */
 		Package(){0x0000FFFF, 0, 0, 18 },
 		Package(){0x0000FFFF, 1, 0, 19 },
 		Package(){0x0000FFFF, 2, 0, 16 },
 		Package(){0x0000FFFF, 3, 0, 17 },
 	})
 
+	/* GPP 2 */
 	Name(PS7, Package(){
-		/* The onboard Ethernet chip - Dev 7 Olivehill Hooked to RTK8111E Ethernet Card x1 Device7-GPP3 J16B*/
 		Package(){0x0000FFFF, 0, INTD, 0 },
 		Package(){0x0000FFFF, 1, INTA, 0 },
 		Package(){0x0000FFFF, 2, INTB, 0 },
 		Package(){0x0000FFFF, 3, INTC, 0 },
 	})
 	Name(APS7, Package(){
-		/* The onboard Ethernet chip - Dev 7 Olivehill Hooked to RTK8111E Ethernet Card x1 Device7-GPP3 J16B*/
 		Package(){0x0000FFFF, 0, 0, 19 },
 		Package(){0x0000FFFF, 1, 0, 16 },
 		Package(){0x0000FFFF, 2, 0, 17 },
 		Package(){0x0000FFFF, 3, 0, 18 },
 	})
 
-	Name(PE0, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 0*/
+	/* GPP 3 */
+	Name(PS8, Package(){
 		Package(){0x0000FFFF, 0, INTA, 0 },
 		Package(){0x0000FFFF, 1, INTB, 0 },
 		Package(){0x0000FFFF, 2, INTC, 0 },
 		Package(){0x0000FFFF, 3, INTD, 0 },
 	})
-	Name(APE0, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 0*/
+	Name(APS8, Package(){
 		Package(){0x0000FFFF, 0, 0, 16 },
 		Package(){0x0000FFFF, 1, 0, 17 },
 		Package(){0x0000FFFF, 2, 0, 18 },
-		Package(){0x0000FFFF, 3, 0, 19 },
-	})
-
-	Name(PE1, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 1*/
-		Package(){0x0000FFFF, 0, INTB, 0 },
-		Package(){0x0000FFFF, 1, INTC, 0 },
-		Package(){0x0000FFFF, 2, INTD, 0 },
-		Package(){0x0000FFFF, 3, INTA, 0 },
-	})
-	Name(APE1, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 1*/
-		Package(){0x0000FFFF, 0, 0, 17 },
-		Package(){0x0000FFFF, 1, 0, 18 },
-		Package(){0x0000FFFF, 2, 0, 19 },
-		Package(){0x0000FFFF, 3, 0, 16 },
-	})
-
-	Name(PE2, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 2*/
-		Package(){0x0000FFFF, 0, INTC, 0 },
-		Package(){0x0000FFFF, 1, INTD, 0 },
-		Package(){0x0000FFFF, 2, INTA, 0 },
-		Package(){0x0000FFFF, 3, INTB, 0 },
-	})
-	Name(APE2, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 2*/
-		Package(){0x0000FFFF, 0, 0, 18 },
-		Package(){0x0000FFFF, 1, 0, 19 },
-		Package(){0x0000FFFF, 2, 0, 16 },
-		Package(){0x0000FFFF, 3, 0, 17 },
-	})
-
-	Name(PE3, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 3 */
-		Package(){0x0000FFFF, 0, INTD, 0 },
-		Package(){0x0000FFFF, 1, INTA, 0 },
-		Package(){0x0000FFFF, 2, INTB, 0 },
-		Package(){0x0000FFFF, 3, INTC, 0 },
-	})
-	Name(APE3, Package(){
-		/* PCIe slot - Hooked to PCIe Bridge 3*/
-		Package(){0x0000FFFF, 0, 0, 19 },
-		Package(){0x0000FFFF, 1, 0, 16 },
-		Package(){0x0000FFFF, 2, 0, 17 },
 		Package(){0x0000FFFF, 3, 0, 18 },
 	})
 
-	/* SB PCI Bridge J21, J22 */
-	Name(PCIB, Package(){
-		/* PCI slots: slot 0, slot 1, slot 2 behind Dev14, Fun4. */
-		Package(){0x0005FFFF, 0, 0, 0x14 },
-		Package(){0x0005FFFF, 1, 0, 0x15 },
-		Package(){0x0005FFFF, 2, 0, 0x16 },
-		Package(){0x0005FFFF, 3, 0, 0x17 },
 
-		Package(){0x0006FFFF, 0, 0, 0x15 },
-		Package(){0x0006FFFF, 1, 0, 0x16 },
-		Package(){0x0006FFFF, 2, 0, 0x17 },
-		Package(){0x0006FFFF, 3, 0, 0x14 },
-/*
-		Package(){0x0007FFFF, 0, 0, 0x16 },
-		Package(){0x0007FFFF, 1, 0, 0x17 },
-		Package(){0x0007FFFF, 2, 0, 0x14 },
-		Package(){0x0007FFFF, 3, 0, 0x15 },
-*/
-	})
 }
diff --git a/src/mainboard/amd/olivehill/devicetree.cb b/src/mainboard/amd/olivehill/devicetree.cb
index dc489d3..075d661 100644
--- a/src/mainboard/amd/olivehill/devicetree.cb
+++ b/src/mainboard/amd/olivehill/devicetree.cb
@@ -1,7 +1,7 @@
 #
 # This file is part of the coreboot project.
 #
-# Copyright (C) 2012 Advanced Micro Devices, Inc.
+# Copyright (C) 2013 Advanced Micro Devices, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -18,6 +18,7 @@
 #
 
 chip northbridge/amd/agesa/family16kb/root_complex
+
 	device cpu_cluster 0 on
 		chip cpu/amd/agesa/family16kb
 			device lapic 0 on  end
@@ -32,7 +33,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
 				device pci 1.0 on  end # Internal Graphics P2P bridge 0x9804
 				device pci 1.1 on  end # Internal Multimedia
 				device pci 2.0 on  end # PCIe Host Bridge
-				device pci 2.1 on  end # x4 PCIe slot
+				device pci 2.1 on  end # x4 PCIe slot 
 				device pci 2.2 on  end # mPCIe slot
 				device pci 2.3 on  end # Realtek NIC
 				device pci 2.4 on  end # Edge Connector
@@ -46,7 +47,7 @@ chip northbridge/amd/agesa/family16kb/root_complex
 				device pci 12.2 on  end # USB
 				device pci 13.0 on  end # USB
 				device pci 13.2 on  end # USB
-				device pci 14.0 on      # SM
+				device pci 14.0 on  # SM
 					chip drivers/generic/generic #dimm 0-0-0
 						device i2c 50 on end
 					end
@@ -73,4 +74,4 @@ chip northbridge/amd/agesa/family16kb/root_complex
 
 		end	#chip northbridge/amd/agesa/family16kb # CPU side of HT root complex
 	end	#domain
-end	#northbridge/amd/agesa/family16kb/root_complex 
\ No newline at end of file
+end	#northbridge/amd/agesa/family16kb/root_complex
diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl
index 2ab0a8c..20a74af 100644
--- a/src/mainboard/amd/olivehill/dsdt.asl
+++ b/src/mainboard/amd/olivehill/dsdt.asl
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2012 Advanced Micro Devices, Inc.
+ * Copyright (C) 2013 Advanced Micro Devices, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -922,7 +922,6 @@ DefinitionBlock (
 			Notify(\_SB.PCI0.UOH4, 0x02) /* NOTIFY_DEVICE_WAKE */
 			Notify(\_SB.PCI0.UOH5, 0x02) /* NOTIFY_DEVICE_WAKE */
 			Notify(\_SB.PCI0.UOH6, 0x02) /* NOTIFY_DEVICE_WAKE */
-			Notify(\_SB.PCI0.UEH1, 0x02) /* NOTIFY_DEVICE_WAKE */
 			Notify(\_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */
 		}
 
@@ -1069,12 +1068,12 @@ DefinitionBlock (
 			}
 			Method(_STA, 0) {
 				/* DBGO("\\_SB\\PCI0\\_STA\n") */
-				Return(0x0B)     /* Status is visible */
+				Return(0x0B)			/* Status is visible */
 			}
 
 			Method(_PRT,0) {
-				If(PMOD){ Return(APR0) }   /* APIC mode */
-				Return (PR0)                  /* PIC Mode */
+				If(PMOD){ Return(APR0) }		/* APIC mode */
+				Return (PR0)				/* PIC Mode */
 			} /* end _PRT */
 
 			/* Describe the Northbridge devices Dev0 ,Func0*/
@@ -1082,126 +1081,103 @@ DefinitionBlock (
 				Name(_ADR, 0x00000000)
 			} /* end AMRT */
 
-#if 1
-			/* Dev3 is also an external GFX bridge */
-			Device(PBR3) {
-				Name(_ADR, 0x00020000)
-				Name(_PRW, Package() {0x18, 4})
-				Method(_PRT,0) {
-					If(PMOD){ Return(APS3) }   /* APIC mode */
-					Return (PS3)                  /* PIC Mode */
-				} /* end _PRT */
-			} /* end PBR3 */
-#endif
-
+			/* Gpp 0 */
 			Device(PBR4) {
 				Name(_ADR, 0x00020001)
 				Name(_PRW, Package() {0x18, 4})
 				Method(_PRT,0) {
-					If(PMOD){ Return(APS4) }   /* APIC mode */
-					Return (PS4)                  /* PIC Mode */
+					If(PMOD){ Return(APS4) }	/* APIC mode */
+					Return (PS4)			/* PIC Mode */
 				} /* end _PRT */
 			} /* end PBR4 */
 
+			/* Gpp 1 */
 			Device(PBR5) {
 				Name(_ADR, 0x00020002)
 				Name(_PRW, Package() {0x18, 4})
 				Method(_PRT,0) {
-					If(PMOD){ Return(APS5) }   /* APIC mode */
-					Return (PS5)                  /* PIC Mode */
+					If(PMOD){ Return(APS5) }	/* APIC mode */
+					Return (PS5)			/* PIC Mode */
 				} /* end _PRT */
 			} /* end PBR5 */
 
+			/* Gpp 2 */
 			Device(PBR6) {
 				Name(_ADR, 0x00020003)
 				Name(_PRW, Package() {0x18, 4})
 				Method(_PRT,0) {
-					If(PMOD){ Return(APS6) }   /* APIC mode */
-					Return (PS6)                  /* PIC Mode */
+					If(PMOD){ Return(APS6) }	/* APIC mode */
+					Return (PS6)			/* PIC Mode */
 				} /* end _PRT */
 			} /* end PBR6 */
 
-			/* The onboard EtherNet chip */
+			/* Gpp 3 */
 			Device(PBR7) {
 				Name(_ADR, 0x00020004)
 				Name(_PRW, Package() {0x18, 4})
 				Method(_PRT,0) {
-					If(PMOD){ Return(APS7) }   /* APIC mode */
-					Return (PS7)                  /* PIC Mode */
+					If(PMOD){ Return(APS7) }	/* APIC mode */
+					Return (PS7)			/* PIC Mode */
 				} /* end _PRT */
 			} /* end PBR7 */
 
-			/* PCI slot 1, 2, 3 */
-			Device(PIBR) {
-				Name(_ADR, 0x00140004)
+			/* Gpp 4 */
+			Device(PBR8) {
+				Name(_ADR, 0x00020004)
 				Name(_PRW, Package() {0x18, 4})
+				Method(_PRT,0) {
+					If(PMOD){ Return(APS8) }	/* APIC mode */
+					Return (PS8)			/* PIC Mode */
+				} /* end _PRT */
+			} /* end PBR8 */
 
-				Method(_PRT, 0) {
-					Return (PCIB)
-				}
-			}
 
 			/* Describe the Southbridge devices */
-			Device(STCR) {
+			Device(STCR) {	/* 0:11.0 - SATA */
 				Name(_ADR, 0x00110000)
 				//#include "acpi/sata.asl"
 			} /* end STCR */
 
-			Device(UOH1) {
+			Device(UOH1) {	/* 0:12.0 - OHCI */
 				Name(_ADR, 0x00120000)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH1 */
 
-			Device(UOH2) {
+			Device(UOH2) {	/* 0:12.2 - EHCI */
 				Name(_ADR, 0x00120002)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH2 */
 
-			Device(UOH3) {
+			Device(UOH3) {	/* 0:13.0 - OHCI */
 				Name(_ADR, 0x00130000)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH3 */
 
-			Device(UOH4) {
+			Device(UOH4) {	/* 0:13.2 - EHCI */
 				Name(_ADR, 0x00130002)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH4 */
 
-			Device(UOH5) {
+			Device(UOH5) {	/* 0:16.0 - OHCI */
 				Name(_ADR, 0x00160000)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH5 */
 
-			Device(UOH6) {
+			Device(UOH6) {	/* 0:16.2 - EHCI */
 				Name(_ADR, 0x00160002)
 				Name(_PRW, Package() {0x0B, 3})
 			} /* end UOH5 */
 
-			Device(UEH1) {
-				Name(_ADR, 0x00140005)
-				Name(_PRW, Package() {0x0B, 3})
-			} /* end UEH1 */
-
-			Device(XHC0) {
+			Device(XHC0) {	/* 0:10.0 - XHCI */
 				Name(_ADR, 0x00100000)
 				Name(_PRW, Package() {0x0B, 4})
 			} /* end XHC0 */
-			Device(XHC1) {
-				Name(_ADR, 0x00100001)
-				Name(_PRW, Package() {0x0B, 4})
-			} /* end XHC1 */
 
-			Device(SBUS) {
+			Device(SBUS) {	/* 0:14.0 - SMBUS */
 				Name(_ADR, 0x00140000)
 			} /* end SBUS */
 
-			/* Primary (and only) IDE channel */
-			Device(IDEC) {
-				Name(_ADR, 0x00140001)
-				//#include "acpi/ide.asl"
-			} /* end IDEC */
-
-			Device(AZHD) {
+			Device(AZHD) {	/* 0:14.2 - HD Audio */
 				Name(_ADR, 0x00140002)
 				OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
 					Field(AZPD, AnyAcc, NoLock, Preserve) {
@@ -1236,7 +1212,7 @@ DefinitionBlock (
 				}
 			} /* end AZHD */
 
-			Device(LIBR) {
+			Device(LIBR) {	/* 0:14.3 - LPC */
 				Name(_ADR, 0x00140003)
 				/* Method(_INI) {
 				*	DBGO("\\_SB\\PCI0\\LpcIsaBr\\_INI\n")
@@ -1328,17 +1304,9 @@ DefinitionBlock (
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
 			} /* end LIBR */
 
-			Device(HPBR) {
-				Name(_ADR, 0x00140004)
-			} /* end HostPciBr */
-
-			Device(ACAD) {
-				Name(_ADR, 0x00140005)
-			} /* end Ac97audio */
-
-			Device(ACMD) {
-				Name(_ADR, 0x00140006)
-			} /* end Ac97modem */
+			Device(SDCN) {	/* 0:14.7 - SD Controller */
+				Name(_ADR, 0x00140007)
+			} /* end SDCN */
 
 			Name(CRES, ResourceTemplate() {
 				IO(Decode16, 0x0CF8, 0x0CF8, 1,	8)
@@ -1368,26 +1336,26 @@ DefinitionBlock (
 
 				Memory32Fixed(READONLY, 0x000A0000, 0x00020000, VGAM) 	/* VGA memory space */
 				Memory32Fixed(READONLY, 0x000C0000, 0x00020000, EMM1)	/* Assume C0000-E0000 empty */
-                                /* memory space for PCI BARs below 4GB */
-                                Memory32Fixed(ReadOnly, 0x00000000, 0x00000000, MMIO)
+				/* memory space for PCI BARs below 4GB */
+				Memory32Fixed(ReadOnly, 0x00000000, 0x00000000, MMIO)
 			}) /* End Name(_SB.PCI0.CRES) */
 
 			Method(_CRS, 0) {
 				/* DBGO("\\_SB\\PCI0\\_CRS\n") */
 				CreateDWordField(CRES, ^MMIO._BAS, MM1B)
-                                CreateDWordField(CRES, ^MMIO._LEN, MM1L)
-                                /*
-                                 * Declare memory between TOM1 and 4GB as available
-                                 * for PCI MMIO.
-                                 * Use ShiftLeft to avoid 64bit constant (for XP).
-                                 * This will work even if the OS does 32bit arithmetic, as
-                                 * 32bit (0x00000000 - TOM1) will wrap and give the same
-                                 * result as 64bit (0x100000000 - TOM1).
-                                 */
-                                Store(TOM1, MM1B)
-                                ShiftLeft(0x10000000, 4, Local0)
-                                Subtract(Local0, TOM1, Local0)
-                                Store(Local0, MM1L)
+				CreateDWordField(CRES, ^MMIO._LEN, MM1L)
+				/*
+				 * Declare memory between TOM1 and 4GB as available
+				 * for PCI MMIO.
+				 * Use ShiftLeft to avoid 64bit constant (for XP).
+				 * This will work even if the OS does 32bit arithmetic, as
+				 * 32bit (0x00000000 - TOM1) will wrap and give the same
+				 * result as 64bit (0x100000000 - TOM1).
+				 */
+				Store(TOM1, MM1B)
+				ShiftLeft(0x10000000, 4, Local0)
+				Subtract(Local0, TOM1, Local0)
+				Store(Local0, MM1L)
 
 				Return(CRES) /* note to change the Name buffer */
 			} /* end of Method(_SB.PCI0._CRS) */



More information about the coreboot-gerrit mailing list