[coreboot-gerrit] New patch to review for coreboot: d060b37 Revert "lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String"

Peter Stuge (peter@stuge.se) gerrit at coreboot.org
Wed Jul 17 22:07:10 CEST 2013


Peter Stuge (peter at stuge.se) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3778

-gerrit

commit d060b3741a456eaf4c73481873c555c1e9f7418a
Author: Peter Stuge <peter at stuge.se>
Date:   Wed Jul 17 22:07:10 2013 +0200

    Revert "lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String"
    
    This reverts commit cd24e3f6a7adecfc9d3b2a2dd2f81d84acffa91b.
    
    Change-Id: I3d1fec75d99d0b480a47b4d433c14a681831d9f8
    Signed-off-by: Peter Stuge <peter at stuge.se>
---
 src/mainboard/lenovo/x60/mainboard.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
index 2f312f0..b344ccb 100644
--- a/src/mainboard/lenovo/x60/mainboard.c
+++ b/src/mainboard/lenovo/x60/mainboard.c
@@ -36,7 +36,6 @@
 #include <pc80/mc146818rtc.h>
 #include "dock.h"
 #include <arch/x86/include/arch/acpigen.h>
-#include <smbios.h>
 #include <x86emu/x86emu.h>
 #define PANEL INT15_5F35_CL_DISPLAY_DEFAULT
 
@@ -134,28 +133,9 @@ static void mainboard_init(device_t dev)
 	}
 }
 
-static int mainboard_smbios_data(device_t dev, int *handle, unsigned long *current)
-{
-	int len;
-#define SERIALBEGIN	"IBM ThinkPad Embedded Controller -["
-#define SERIAL		"01234567890123456"
-#define SERIALEND	"]-"
-	char tpec[] = SERIALBEGIN SERIAL SERIALEND;
-
-	const char *oem_strings[] = {
-		tpec,
-	};
-
-	h8_build_id_and_function_spec_version(tpec + sizeof(SERIALBEGIN), sizeof(SERIAL));
-	len = smbios_write_type11(current, (*handle)++, oem_strings, ARRAY_SIZE(oem_strings));
-
-	return len;
-}
-
 static void mainboard_enable(device_t dev)
 {
 	dev->ops->init = mainboard_init;
-	dev->ops->get_smbios_data = mainboard_smbios_data;
 }
 
 struct chip_operations mainboard_ops = {



More information about the coreboot-gerrit mailing list