[coreboot-gerrit] Patch set updated for coreboot: 4dd83bb cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Wed Jul 17 18:39:51 CEST 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3468

-gerrit

commit 4dd83bbe10f5c9469e717187dc7c2310cf4e2164
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Jun 14 23:42:45 2013 +0200

    cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors
    
    Many CPU families no longer need the double startup IPI.
    Add CPU_AMD_AGESA as one indicator that it is not needed,
    as all AMD processors using AGESA – currently
    Family 10h to 15h – should not need it.
    
    Successfully tested on ASRock E350M1 with a Family 14h processor.
    
    This is a kludgy approach but it works.
    
    Change-Id: Ib310f2e5ab4b463a82bf0fa9fa9141b556cabf60
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/cpu/x86/lapic/lapic_cpu_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c
index fbc8aa4..08cbe96 100644
--- a/src/cpu/x86/lapic/lapic_cpu_init.c
+++ b/src/cpu/x86/lapic/lapic_cpu_init.c
@@ -167,7 +167,7 @@ static int lapic_start_cpu(unsigned long apicid)
 		return 0;
 	}
 
-#if !CONFIG_CPU_AMD_MODEL_10XXX
+#if !CONFIG_CPU_AMD_MODEL_10XXX && !CONFIG_CPU_AMD_AGESA
 	num_starts = 2;
 #else
 	num_starts = 1;



More information about the coreboot-gerrit mailing list