[coreboot-gerrit] New patch to review for coreboot: 01cd968 Move the HAVE_ARCH_* config options from src/arch/x86 to src/.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Thu Jul 11 05:39:09 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3760

-gerrit

commit 01cd9684034c03671c421b02369e6263f65cf8a8
Author: Gabe Black <gabeblack at google.com>
Date:   Sun Jul 7 13:52:37 2013 -0700

    Move the HAVE_ARCH_* config options from src/arch/x86 to src/.
    
    The options that keep track of whether there are arch versions of the standard
    string functions shouldn't be in the arch/x86 directory since they apply to
    all architectures. Move them into the higher level, shared Kconfig defaulting
    to off. Then, in each applicable arch (currently all of them) they can be
    selected to on.
    
    Change-Id: I7ea64a583230fdc28773f17fd7cc23e0f0a5f3d6
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/Kconfig            |  8 ++++++++
 src/arch/armv7/Kconfig |  7 +++++++
 src/arch/x86/Kconfig   | 14 ++++++--------
 3 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index fdf40e5..14e7801 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -236,6 +236,14 @@ if ARCH_ARMV7
 source src/arch/armv7/Kconfig
 endif
 
+config HAVE_ARCH_MEMSET
+	bool
+	default n
+
+config HAVE_ARCH_MEMCPY
+	bool
+	default n
+
 menu "Chipset"
 
 comment "CPU"
diff --git a/src/arch/armv7/Kconfig b/src/arch/armv7/Kconfig
index 633c5ef..048f069 100644
--- a/src/arch/armv7/Kconfig
+++ b/src/arch/armv7/Kconfig
@@ -1,5 +1,12 @@
 menu "Architecture (armv7)"
 
+
+config ARM_ARCH_OPTIONS
+	bool
+	default y
+	select HAVE_ARCH_MEMSET
+	select HAVE_ARCH_MEMCPY
+
 # Maximum reboot count
 # TODO: Improve description.
 config MAX_REBOOT_CNT
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 95fc172..287e2bc 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -1,5 +1,11 @@
 menu "Architecture (x86)"
 
+config X86_ARCH_OPTIONS
+	bool
+	default y
+	select HAVE_ARCH_MEMSET
+	select HAVE_ARCH_MEMCPY
+
 config MARK_GRAPHICS_MEM_WRCOMB
 	bool "Mark graphics memory as write-combining."
 	default n
@@ -95,14 +101,6 @@ config CMOS_DEFAULT_FILE
 config BOOTBLOCK_SOUTHBRIDGE_INIT
 	string
 
-config HAVE_ARCH_MEMSET
-	bool
-	default y
-
-config HAVE_ARCH_MEMCPY
-	bool
-	default y
-
 config IOAPIC_INTERRUPTS_ON_FSB
 	bool
 	default y if !IOAPIC_INTERRUPTS_ON_APIC_SERIAL_BUS



More information about the coreboot-gerrit mailing list