[coreboot-gerrit] Patch set updated for coreboot: 313e88d lenovo/x60: Move mainboard_enable() code into a mainboard_init()

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Jul 11 01:54:56 CEST 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3619

-gerrit

commit 313e88dce55c600b29c3f760356c62a5299f7f9f
Author: Peter Stuge <peter at stuge.se>
Date:   Sat Jul 6 20:05:13 2013 +0200

    lenovo/x60: Move mainboard_enable() code into a mainboard_init()
    
    mainboard_enable() is now modelled after google/parrot where the
    enable function only sets dev->ops->init for the root device to
    point to a mainboard_init() function, which in turn is called in a
    later pass over the device tree to do the actual initialization.
    
    Change-Id: Iaf9187532a1e432b991260201b95dda85cc312c5
    Signed-off-by: Peter Stuge <peter at stuge.se>
---
 src/mainboard/lenovo/x60/mainboard.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
index d2d0733..b344ccb 100644
--- a/src/mainboard/lenovo/x60/mainboard.c
+++ b/src/mainboard/lenovo/x60/mainboard.c
@@ -85,7 +85,7 @@ int get_cst_entries(acpi_cstate_t **entries)
 	return ARRAY_SIZE(cst_entries);
 }
 
-static void mainboard_enable(device_t dev)
+static void mainboard_init(device_t dev)
 {
 	device_t dev0, idedev, sdhci_dev;
 
@@ -133,6 +133,11 @@ static void mainboard_enable(device_t dev)
 	}
 }
 
+static void mainboard_enable(device_t dev)
+{
+	dev->ops->init = mainboard_init;
+}
+
 struct chip_operations mainboard_ops = {
 	.enable_dev = mainboard_enable,
 };



More information about the coreboot-gerrit mailing list