[coreboot-gerrit] Patch merged into coreboot/master: 7cced0d ec: Add romstage function for checking and rebooting EC

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 10 21:44:23 CEST 2013


the following patch was just integrated into master:
commit 7cced0d20e44c1bbcd0b5d4aced53c682fcd23fc
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Jun 4 10:03:34 2013 -0700

    ec: Add romstage function for checking and rebooting EC
    
    Now that we are executing VbInit() in coreboot we can end up
    in a situation where the recovery reason is consumed during
    VbInit (end of romstage) and then the EC is rebooted to RO
    during ramstage EC init, thereby losing the recovery reason.
    
    Two possiblities are to remove the EC check+reboot from ramstage
    and let it happen in depthcharge.  This however means that the
    system has to boot all the way into depthcharge and then reboot
    the EC and the system again.
    
    Instead if we do a check in romstage before VbInit() is called
    then we can reboot the EC into RO early and avoid booting all
    the way to depthcharge first.
    
    This change adds a ramstage version the EC init function and
    calls it from the shared romstage code immediately after the
    PCH decode windows are setup.
    
    Change-Id: I30d2a0c7131b8e4ec30c63eea36944ec111a8fba
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/3744
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3744 for details.

-gerrit



More information about the coreboot-gerrit mailing list