[coreboot-gerrit] Patch merged into coreboot/master: 800790d ARM: Fix up page table/cachability management.

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 10 21:06:35 CEST 2013


the following patch was just integrated into master:
commit 800790d4e1e4817a140c706a32b5448cbd9d0c45
Author: Gabe Black <gabeblack at google.com>
Date:   Sat May 18 22:45:54 2013 -0700

    ARM: Fix up page table/cachability management.
    
    When modifying the page tables, use writel to ensure the writes happen, flush
    the page tables themselves to ensure they're visible to the MMU if it doesn't
    look at the caches, and invalidate the right TLB entries.
    
    The first two changes are probably safer but may not be strictly necessary.
    The third change is necessary because we were invalidating the TLB using i
    which was in megabytes but using an instruction that expects an address in
    bytes.
    
    One symptom of this problem was that the framebuffer, which was supposed to be
    marked uncacheable, was only being partially updated since some of the updates
    were still in the cache. With this change the graphics show up correctly.
    
    Change-Id: I5475df29690371459b0d37a304eebc62f81dd76b
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-on: http://review.coreboot.org/3653
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3653 for details.

-gerrit



More information about the coreboot-gerrit mailing list