[coreboot-gerrit] Patch set updated for coreboot: 82445fc w83627hf/acpi: Fix endianess error in floppy drive enumeration code

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Wed Jul 10 00:04:38 CEST 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3602

-gerrit

commit 82445fc8bd749b00a7af9492f249aa0645715a70
Author: Christoph Grenz <christophg+cb at grenz-bonn.de>
Date:   Thu Jul 4 02:51:42 2013 +0200

    w83627hf/acpi: Fix endianess error in floppy drive enumeration code
    
    The enumeration results are stored as five DWORDs in one 20 byte buffer.
    Bytes 3, 7, 11 and 15 were used to set the lowest bit of each DWORD.
    ACPI uses little endian, so 1, 4, 8 and 12 are the correct indices.
    
    Change-Id: I793225cb1bb62fd148ecfa1e61e02f5d7be62cdb
    Signed-off-by: Christoph Grenz <christophg+cb at grenz-bonn.de>
---
 src/superio/winbond/w83627hf/acpi/superio.asl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index 03f72f7..05b570b 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -356,10 +356,10 @@ Device(SIO) {
 				SIFR, 8
 			}
 
-			CreateByteField (_FDE, 3, FD1)
-			CreateByteField (_FDE, 7, FD2)
-			CreateByteField (_FDE, 11, FD3)
-			CreateByteField (_FDE, 15, FD4)
+			CreateByteField (_FDE, 1, FD1)
+			CreateByteField (_FDE, 4, FD2)
+			CreateByteField (_FDE, 8, FD3)
+			CreateByteField (_FDE, 12, FD4)
 
 			Store(One, ACT1)
 			Store(0, SELE)



More information about the coreboot-gerrit mailing list