[coreboot-gerrit] New patch to review for coreboot: edcb779 armv7/exynos5420: Remove the extra reopen when reading SPI.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Jul 9 05:29:45 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3715

-gerrit

commit edcb779f5c9fb2ab3dd42dcb04705fdca251b199
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Wed Jun 26 21:22:55 2013 +0800

    armv7/exynos5420: Remove the extra reopen when reading SPI.
    
    The workaround of re-opening device in exynos_spi_read has been fixed by the new
    correct open/close and xfer procedure. It's safe to be removed now.
    
    Change-Id: I6b1bf717c916903999a137998a578b0a866829bd
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/cpu/samsung/exynos5420/spi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/cpu/samsung/exynos5420/spi.c b/src/cpu/samsung/exynos5420/spi.c
index 906f6a7..1c60378 100644
--- a/src/cpu/samsung/exynos5420/spi.c
+++ b/src/cpu/samsung/exynos5420/spi.c
@@ -364,9 +364,6 @@ static size_t exynos_spi_cbfs_read(struct cbfs_media *media, void *dest,
 	int bytes;
 	DEBUG_SPI("exynos_spi_cbfs_read(%u)\n", count);
 	bytes = exynos_spi_read(spi->slave, dest, count, offset);
-	// Flush and re-open the device.
-	spi_release_bus(spi->slave);
-	spi_claim_bus(spi->slave);
 	return bytes;
 }
 



More information about the coreboot-gerrit mailing list