[coreboot-gerrit] Patch set updated for coreboot: fc2357f w83627hf/acpi: Fix logical device power down in ACPI
Christoph Grenz (christophg+cb@grenz-bonn.de)
gerrit at coreboot.org
Sat Jul 6 17:25:06 CEST 2013
Christoph Grenz (christophg+cb at grenz-bonn.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3605
-gerrit
commit fc2357fc57c254111d73bb0294f00c8c3ee61924
Author: Christoph Grenz <christophg+cb at grenz-bonn.de>
Date: Thu Jul 4 03:41:39 2013 +0200
w83627hf/acpi: Fix logical device power down in ACPI
As Nico noticed for the W83627DHG, the power management bits to power down
individual logical devices on Winbond superios are named counterintuitively
and need to be set when the logical device should be powered.
This corrects the power management methods for the W83627HF.
Change-Id: I98bccd550a0513c62bfa9480275f88c566691bc8
Signed-off-by: Christoph Grenz <christophg+cb at grenz-bonn.de>
---
src/superio/winbond/w83627hf/acpi/superio.asl | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index efb7fba..427d63c 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -242,13 +242,13 @@ Device(SIO) {
/* Disable power saving mode */
Method (_PS0) {
ENCM (0xFF)
- Store (Zero, FDPW)
+ Store (One, FDPW)
EXCM ()
}
/* Enable power saving mode */
Method (_PS1) {
ENCM (0xFF)
- Store (One, FDPW)
+ Store (Zero, FDPW)
EXCM ()
}
@@ -462,12 +462,12 @@ Device(SIO) {
}
Method (_PS0) {
ENCM (0xFF)
- Store (Zero, PRPW)
+ Store (One, PRPW)
EXCM ()
}
Method (_PS1) {
ENCM (0xFF)
- Store (One, PRPW)
+ Store (Zero, PRPW)
EXCM ()
}
@@ -639,12 +639,12 @@ Device(SIO) {
}
Method (_PS0) {
ENCM (0xFF)
- Store (Zero, UAPW)
+ Store (One, UAPW)
EXCM ()
}
Method (_PS1) {
ENCM (0xFF)
- Store (One, UAPW)
+ Store (Zero, UAPW)
EXCM ()
}
@@ -764,12 +764,12 @@ Device(SIO) {
}
Method (_PS0) {
ENCM (0xFF)
- Store (Zero, UBPW)
+ Store (One, UBPW)
EXCM ()
}
Method (_PS1) {
ENCM (0xFF)
- Store (One, UBPW)
+ Store (Zero, UBPW)
EXCM ()
}
@@ -889,12 +889,12 @@ Device(SIO) {
}
Method (_PS0) {
ENCM (0xFF)
- Store (Zero, UBPW)
+ Store (One, UBPW)
EXCM ()
}
Method (_PS1) {
ENCM (0xFF)
- Store (One, UBPW)
+ Store (Zero, UBPW)
EXCM ()
}
@@ -1414,14 +1414,14 @@ Device(SIO) {
Method (_PS0)
{
ENCM (0xFF)
- Store (Zero, HWPW)
+ Store (One, HWPW)
EXCM ()
}
Method (_PS1)
{
ENCM (0xFF)
- Store (One, HWPW)
+ Store (Zero, HWPW)
EXCM ()
}
More information about the coreboot-gerrit
mailing list