[coreboot-gerrit] New patch to review for coreboot: 67c421e Move select MMCONF_SUPPORT under northbridge (fix)

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jul 4 01:10:09 CEST 2013


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3598

-gerrit

commit 67c421e854fede03f3eccef3292ad21f46c93427
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Jul 2 11:37:35 2013 +0300

    Move select MMCONF_SUPPORT under northbridge (fix)
    
    I missed the board with gm45 when I moved MMCONF_SUPPORT lines.
    
    Also, the intel/i3100 does not have MMCONF_SUPPORT implemented
    even though it was previously selected for intel/eagleheights board.
    
    Change-Id: I9c7f6b0a150b4d54288a1e015277b9d98467fca4
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/roda/rk9/Kconfig      | 1 -
 src/northbridge/intel/gm45/Kconfig  | 1 +
 src/northbridge/intel/i3100/Kconfig | 1 -
 3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig
index 4bf9088..59ae455 100644
--- a/src/mainboard/roda/rk9/Kconfig
+++ b/src/mainboard/roda/rk9/Kconfig
@@ -7,7 +7,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select NORTHBRIDGE_INTEL_GM45
 	select SOUTHBRIDGE_INTEL_I82801IX
 	select SUPERIO_SMSC_LPC47N227
-	select MMCONF_SUPPORT
 	select BOARD_ROMSIZE_KB_4096
 	select RTL8168_ROM_DISABLE
 	select DRIVERS_GENERIC_IOAPIC
diff --git a/src/northbridge/intel/gm45/Kconfig b/src/northbridge/intel/gm45/Kconfig
index 34b2544..16a0bf1 100644
--- a/src/northbridge/intel/gm45/Kconfig
+++ b/src/northbridge/intel/gm45/Kconfig
@@ -25,6 +25,7 @@ if NORTHBRIDGE_INTEL_GM45
 config NORTHBRIDGE_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select HAVE_DEBUG_RAM_SETUP
+	select MMCONF_SUPPORT
 	select MMCONF_SUPPORT_DEFAULT
 	select IOMMU
 
diff --git a/src/northbridge/intel/i3100/Kconfig b/src/northbridge/intel/i3100/Kconfig
index 2bb1a25..079004b 100644
--- a/src/northbridge/intel/i3100/Kconfig
+++ b/src/northbridge/intel/i3100/Kconfig
@@ -1,6 +1,5 @@
 config NORTHBRIDGE_INTEL_I3100
 	bool
-	select MMCONF_SUPPORT
 
 if NORTHBRIDGE_INTEL_I3100
 config DIMM_MAP_LOGICAL



More information about the coreboot-gerrit mailing list