[coreboot-gerrit] Patch set updated for coreboot: d84b24d Coding style: punctuation cleanup [1/2].

Idwer Vollering (vidwer@gmail.com) gerrit at coreboot.org
Mon Dec 23 01:28:07 CET 2013


Idwer Vollering (vidwer at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4562

-gerrit

commit d84b24d3e2e092fdbd6569f6a01e186f5a3a2519
Author: Idwer Vollering <vidwer at gmail.com>
Date:   Sun Dec 22 21:38:18 2013 +0000

    Coding style: punctuation cleanup [1/2].
    
    Clean up superfluous line terminators.
    
    Change-Id: If837b4f1b3e7702cbb09ba12f53ed788a8f31386
    Signed-off-by: Idwer Vollering <vidwer at gmail.com>
---
 src/drivers/i2c/rtd2132/rtd2132.c            | 2 +-
 src/ec/quanta/it8518/ec.c                    | 4 ++--
 src/lib/cbfs.c                               | 2 +-
 src/lib/dynamic_cbmem.c                      | 2 +-
 src/mainboard/google/bolt/smihandler.c       | 2 +-
 src/mainboard/google/falco/smihandler.c      | 2 +-
 src/mainboard/google/link/mainboard_smi.c    | 2 +-
 src/mainboard/google/parrot/chromeos.c       | 2 +-
 src/mainboard/google/peppy/smihandler.c      | 2 +-
 src/mainboard/google/slippy/smihandler.c     | 2 +-
 src/northbridge/amd/amdmct/wrappers/mcti_d.c | 2 +-
 src/northbridge/intel/i5000/raminit.c        | 4 ++--
 src/northbridge/via/vx800/detection.c        | 2 +-
 src/northbridge/via/vx800/freq_setting.c     | 2 +-
 src/northbridge/via/vx900/raminit_ddr3.c     | 4 ++--
 src/southbridge/amd/cimx/sb800/spi.c         | 2 +-
 src/southbridge/amd/sb700/sm.c               | 2 +-
 src/southbridge/amd/sb800/early_setup.c      | 2 +-
 src/southbridge/intel/i82371eb/fadt.c        | 2 +-
 src/southbridge/nvidia/mcp55/fadt.c          | 2 +-
 src/southbridge/via/vt8237r/fadt.c           | 2 +-
 21 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c
index 22a9f03..44333ac 100644
--- a/src/drivers/i2c/rtd2132/rtd2132.c
+++ b/src/drivers/i2c/rtd2132/rtd2132.c
@@ -181,7 +181,7 @@ static void rtd2132_lvds_swap(device_t dev,
 	if (cfg->lvds_swap & RTD2132_LVDS_SWAP_CFG_DUAL)
 		swap_value |= RTD2132_LVDS_SWAP_DUAL;
 
-	printk(BIOS_INFO, "RTD2132: LVDS Swap 0x%02x\n", swap_value);;
+	printk(BIOS_INFO, "RTD2132: LVDS Swap 0x%02x\n", swap_value);
 
 	rtd2132_write_reg(dev, RTD2132_COMMAND_LVDS_SWAP, swap_value);
 }
diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c
index 4798cee..6516cee 100644
--- a/src/ec/quanta/it8518/ec.c
+++ b/src/ec/quanta/it8518/ec.c
@@ -40,7 +40,7 @@ static int input_buffer_empty(u16 status_reg)
 	u32 timeout;
 	for(timeout = KBC_TIMEOUT_IN_MS; timeout && (inb(status_reg) & KBD_IBF);
 	    timeout--) {
-		udelay(1000);;
+		udelay(1000);
 	}
 
 	if (!timeout) {
@@ -56,7 +56,7 @@ static int output_buffer_full(u16 status_reg)
 	u32 timeout;
 	for(timeout = KBC_TIMEOUT_IN_MS; timeout && ((inb(status_reg)
 	    & KBD_OBF) == 0); timeout--) {
-		udelay(1000);;
+		udelay(1000);
 	}
 
 	if (!timeout) {
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 23e1600..1f44695 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -312,7 +312,7 @@ void *cbfs_load_payload(struct cbfs_media *media, const char *name)
 void *cbfs_simple_buffer_map(struct cbfs_simple_buffer *buffer,
 			     struct cbfs_media *media,
 			     size_t offset, size_t count) {
-	void *address = buffer->buffer + buffer->allocated;;
+	void *address = buffer->buffer + buffer->allocated;
 	DEBUG("simple_buffer_map(offset=%zd, count=%zd): "
 	      "allocated=%zd, size=%zd, last_allocate=%zd\n",
 	    offset, count, buffer->allocated, buffer->size,
diff --git a/src/lib/dynamic_cbmem.c b/src/lib/dynamic_cbmem.c
index e21f96e..b934aed 100644
--- a/src/lib/dynamic_cbmem.c
+++ b/src/lib/dynamic_cbmem.c
@@ -294,7 +294,7 @@ const struct cbmem_entry *cbmem_entry_add(u32 id, u64 size64)
 {
 	struct cbmem_root *root;
 	const struct cbmem_entry *entry;
-	unsigned long base;;
+	unsigned long base;
 	u32 size;
 	u32 aligned_size;
 
diff --git a/src/mainboard/google/bolt/smihandler.c b/src/mainboard/google/bolt/smihandler.c
index 7b7dd69..b392852 100644
--- a/src/mainboard/google/bolt/smihandler.c
+++ b/src/mainboard/google/bolt/smihandler.c
@@ -149,7 +149,7 @@ int mainboard_smi_apmc(u8 apmc)
 		google_chromeec_set_sci_mask(0);
 		/* Clear all pending events */
 		while (google_chromeec_get_event() != 0);
-		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);;
+		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
 		break;
 	}
 	return 0;
diff --git a/src/mainboard/google/falco/smihandler.c b/src/mainboard/google/falco/smihandler.c
index bf2165f..511bfc5 100644
--- a/src/mainboard/google/falco/smihandler.c
+++ b/src/mainboard/google/falco/smihandler.c
@@ -166,7 +166,7 @@ int mainboard_smi_apmc(u8 apmc)
 		google_chromeec_set_sci_mask(0);
 		/* Clear all pending events */
 		while (google_chromeec_get_event() != 0);
-		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);;
+		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
 		break;
 	}
 	return 0;
diff --git a/src/mainboard/google/link/mainboard_smi.c b/src/mainboard/google/link/mainboard_smi.c
index 3785121..c545a86 100644
--- a/src/mainboard/google/link/mainboard_smi.c
+++ b/src/mainboard/google/link/mainboard_smi.c
@@ -153,7 +153,7 @@ int mainboard_smi_apmc(u8 apmc)
 		google_chromeec_set_sci_mask(0);
 		/* Clear all pending events */
 		while (google_chromeec_get_event() != 0);
-		google_chromeec_set_smi_mask(LINK_EC_SMI_EVENTS);;
+		google_chromeec_set_smi_mask(LINK_EC_SMI_EVENTS);
 		break;
 	}
 	return 0;
diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c
index 8a647dc..6f50a79 100644
--- a/src/mainboard/google/parrot/chromeos.c
+++ b/src/mainboard/google/parrot/chromeos.c
@@ -72,7 +72,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 	/* Lid switch GPIO active high (open). */
 	gpios->gpios[3].port = 15;
 	gpios->gpios[3].polarity = ACTIVE_HIGH;
-	gpios->gpios[3].value = ((gp_lvl >> 15) & 1);;
+	gpios->gpios[3].value = ((gp_lvl >> 15) & 1);
 	strncpy((char *)gpios->gpios[3].name,"lid", GPIO_MAX_NAME_LENGTH);
 
 	/* Power Button */
diff --git a/src/mainboard/google/peppy/smihandler.c b/src/mainboard/google/peppy/smihandler.c
index f225468..e95dc4c 100644
--- a/src/mainboard/google/peppy/smihandler.c
+++ b/src/mainboard/google/peppy/smihandler.c
@@ -163,7 +163,7 @@ int mainboard_smi_apmc(u8 apmc)
 		google_chromeec_set_sci_mask(0);
 		/* Clear all pending events */
 		while (google_chromeec_get_event() != 0);
-		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);;
+		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
 		break;
 	}
 	return 0;
diff --git a/src/mainboard/google/slippy/smihandler.c b/src/mainboard/google/slippy/smihandler.c
index dd0a605..f8eac31 100644
--- a/src/mainboard/google/slippy/smihandler.c
+++ b/src/mainboard/google/slippy/smihandler.c
@@ -150,7 +150,7 @@ int mainboard_smi_apmc(u8 apmc)
 		google_chromeec_set_sci_mask(0);
 		/* Clear all pending events */
 		while (google_chromeec_get_event() != 0);
-		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);;
+		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
 		break;
 	}
 	return 0;
diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
index d6860b2..8c45332 100644
--- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c
+++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
@@ -48,7 +48,7 @@ static u16 mctGet_NVbits(u8 index)
 		//val =  200;	/* 200MHz(DDR400) */
 		//val =  266;	/* 266MHz(DDR533) */
 		//val =  333;	/* 333MHz(DDR667) */
-		val =  MEM_MAX_LOAD_FREQ;;	/* 400MHz(DDR800) */
+		val =  MEM_MAX_LOAD_FREQ;	/* 400MHz(DDR800) */
 		break;
 	case NV_ECC_CAP:
 #if SYSTEM_TYPE == SERVER
diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c
index 7055c7a..4be7d5d 100644
--- a/src/northbridge/intel/i5000/raminit.c
+++ b/src/northbridge/intel/i5000/raminit.c
@@ -1283,8 +1283,8 @@ static void i5000_setup_interleave(struct i5000_fbd_setup *setup)
 	}
 
 	printk(BIOS_DEBUG, "MIR0: %04x\n", mir0);
-	printk(BIOS_DEBUG, "MIR1: %04x\n", mir1);;
-	printk(BIOS_DEBUG, "MIR2: %04x\n", mir2);;
+	printk(BIOS_DEBUG, "MIR1: %04x\n", mir1);
+	printk(BIOS_DEBUG, "MIR2: %04x\n", mir2);
 
 	pci_write_config16(dev16, I5000_MIR0, mir0);
 	pci_write_config16(dev16, I5000_MIR1, mir1);
diff --git a/src/northbridge/via/vx800/detection.c b/src/northbridge/via/vx800/detection.c
index eb1ddcc..69e520c 100644
--- a/src/northbridge/via/vx800/detection.c
+++ b/src/northbridge/via/vx800/detection.c
@@ -180,7 +180,7 @@ CB_STATUS GetInfoFromSPD(DRAM_SYS_ATTR *DramAttr)
 				DramAttr->DimmNumChB++;
 				DramAttr->LoadNumChB =
 				    (u8) (DramAttr->LoadNumChB * LoadNum *
-					  RankNum);;
+					  RankNum);
 			}
 			RankNum |= 1; /* Set rank map. */
 			DramAttr->RankPresentMap |= (RankNum << (Sockets * 2));
diff --git a/src/northbridge/via/vx800/freq_setting.c b/src/northbridge/via/vx800/freq_setting.c
index 65b058a..55a6316 100644
--- a/src/northbridge/via/vx800/freq_setting.c
+++ b/src/northbridge/via/vx800/freq_setting.c
@@ -65,7 +65,7 @@ void DRAMFreqSetting(DRAM_SYS_ATTR * DramAttr)
 		Data = (u8) ((Data & 0xf8) | 6);
 		break;
 	default:
-		Data = (u8) ((Data & 0xf8) | 1);;
+		Data = (u8) ((Data & 0xf8) | 1);
 	}
 	pci_write_config8(MEMCTRL, 0x90, Data);
 
diff --git a/src/northbridge/via/vx900/raminit_ddr3.c b/src/northbridge/via/vx900/raminit_ddr3.c
index 1c052c0..f148ffe 100644
--- a/src/northbridge/via/vx900/raminit_ddr3.c
+++ b/src/northbridge/via/vx900/raminit_ddr3.c
@@ -426,7 +426,7 @@ static void vx900_dram_phys_bank_range(const dimm_info * dimms,
 		} else {
 			/* Otherwise, everything is held in the first bank */
 			ranks->phys_rank_size_mb[i << 1] = size;
-			ranks->phys_rank_size_mb[(i << 1) | 1] = 0;;
+			ranks->phys_rank_size_mb[(i << 1) | 1] = 0;
 		}
 	}
 }
@@ -1294,7 +1294,7 @@ static void vx900_dram_calibrate_transmit_delays(delay_range * tx_dq,
 {
 	/* Same timeout reasoning as in receive delays */
 	size_t n_tries = 0;
-	int dq_tries = 0, dqs_tries = 0;;
+	int dq_tries = 0, dqs_tries = 0;
 	const size_t max_tries = 100;
 	for (;;) {
 		if (n_tries++ >= max_tries) {
diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c
index d85a515..3b2f556 100644
--- a/src/southbridge/amd/cimx/sb800/spi.c
+++ b/src/southbridge/amd/cimx/sb800/spi.c
@@ -117,7 +117,7 @@ static void ImcSleep(void)
 static void ImcWakeup(void)
 {
 	u8	cmd_val = 0x96;		/* Kick off IMC Mailbox command 96 */
-	u8	reg0_val = 0;;		/* clear response register */
+	u8	reg0_val = 0;		/* clear response register */
 	u8	reg1_val = 0xB5;	/* release ownership flag */
 
 	WriteECmsg (MSG_REG0, AccWidthUint8, &reg0_val);
diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c
index 2c2f6d5..0fb6556 100644
--- a/src/southbridge/amd/sb700/sm.c
+++ b/src/southbridge/amd/sb700/sm.c
@@ -151,7 +151,7 @@ static void sm_init(device_t dev)
 	pm_iowrite(0x55, byte);
 
 	byte = pm_ioread(0xD7);
-	byte |= 1 << 6 | 1 << 1;;
+	byte |= 1 << 6 | 1 << 1;
 	pm_iowrite(0xD7, byte);
 
 	/* 2.15 */
diff --git a/src/southbridge/amd/sb800/early_setup.c b/src/southbridge/amd/sb800/early_setup.c
index b3d16bf..213cae9 100644
--- a/src/southbridge/amd/sb800/early_setup.c
+++ b/src/southbridge/amd/sb800/early_setup.c
@@ -276,7 +276,7 @@ void sb800_pci_port80(void)
 	pci_write_config8(dev, 0x04, byte);
 
 	/* LPC controller */
-	dev = PCI_DEV(0, 0x14, 3);;//pci_locate_device(PCI_ID(0x1002, 0x439D), 0);
+	dev = PCI_DEV(0, 0x14, 3);//pci_locate_device(PCI_ID(0x1002, 0x439D), 0);
 
 	byte = pci_read_config8(dev, 0x4A);
 	byte &= ~(1 << 5);	/* disable lpc port 80 */
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index e4c8208..09874f7 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -212,7 +212,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
 	fadt->x_gpe0_blk.addrh = 0x0;
 
 	fadt->x_gpe1_blk.space_id = 1;
-	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;;
+	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;
 	fadt->x_gpe1_blk.bit_offset = 0;
 	fadt->x_gpe1_blk.resv = 0;
 	fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;
diff --git a/src/southbridge/nvidia/mcp55/fadt.c b/src/southbridge/nvidia/mcp55/fadt.c
index f9ac8ee..68f03e0 100644
--- a/src/southbridge/nvidia/mcp55/fadt.c
+++ b/src/southbridge/nvidia/mcp55/fadt.c
@@ -163,7 +163,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
 	fadt->x_gpe0_blk.addrh = 0x0;
 
 	fadt->x_gpe1_blk.space_id = 1;
-	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;;
+	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;
 	fadt->x_gpe1_blk.bit_offset = 0;
 	fadt->x_gpe1_blk.resv = 0;
 	fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;
diff --git a/src/southbridge/via/vt8237r/fadt.c b/src/southbridge/via/vt8237r/fadt.c
index 5b3bc56..ecd81b3 100644
--- a/src/southbridge/via/vt8237r/fadt.c
+++ b/src/southbridge/via/vt8237r/fadt.c
@@ -163,7 +163,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
 	fadt->x_gpe0_blk.addrh = 0x0;
 
 	fadt->x_gpe1_blk.space_id = 1;
-	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;;
+	fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;
 	fadt->x_gpe1_blk.bit_offset = 0;
 	fadt->x_gpe1_blk.resv = 0;
 	fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;



More information about the coreboot-gerrit mailing list