[coreboot-gerrit] Patch set updated for coreboot: efd5ba4 exynos5420: configure SD_0_CDn as VDDEN for eMMC

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 21:19:30 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4445

-gerrit

commit efd5ba40a0c2bcc8d2f827501260c19ccff6f44b
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Aug 8 14:51:07 2013 -0700

    exynos5420: configure SD_0_CDn as VDDEN for eMMC
    
    On Exynos5420 the MMC channel 0 is connected to eMMC
    Which does not have a card detection pin. Also this pin
    is connected as VDDEN to PMIC.
    
    This is ported from https://gerrit.chromium.org/gerrit/#/c/60732/
    
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    
    Change-Id: I19048d22b7dd00df1716b6b5b332a7eb70fe0836
    Reviewed-on: https://gerrit.chromium.org/gerrit/65247
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Commit-Queue: David Hendricks <dhendrix at chromium.org>
    Tested-by: David Hendricks <dhendrix at chromium.org>
---
 src/cpu/samsung/exynos5420/pinmux.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/cpu/samsung/exynos5420/pinmux.c b/src/cpu/samsung/exynos5420/pinmux.c
index 843a6db..573cdb6 100644
--- a/src/cpu/samsung/exynos5420/pinmux.c
+++ b/src/cpu/samsung/exynos5420/pinmux.c
@@ -81,7 +81,14 @@ static void exynos_pinmux_sdmmc(int start, int start_ext)
 void exynos_pinmux_sdmmc0(void)
 {
 	exynos_pinmux_sdmmc(GPIO_C00, GPIO_C30);
-	gpio_set_pull(GPIO_C02, GPIO_PULL_UP);
+	/*
+	 * MMC0 is intended to be used for eMMC. The card detect pin is used
+	 * as a VDDEN signal to power on the eMMC. The 5420 iROM makes this
+	 * same assumption.
+	 */
+	gpio_set_pull(GPIO_C02, GPIO_PULL_NONE);
+	gpio_cfg_pin(GPIO_C02, GPIO_OUTPUT);
+	gpio_set_value(GPIO_C02, 1);
 }
 
 void exynos_pinmux_sdmmc1(void)



More information about the coreboot-gerrit mailing list