[coreboot-gerrit] Patch merged into coreboot/master: 21729b7 kirby: pit: Fix up wakeup_need_reset

gerrit at coreboot.org gerrit at coreboot.org
Sat Dec 21 21:02:25 CET 2013


the following patch was just integrated into master:
commit 21729b76649d3e5ab419d5e74f01e7dfe71dc402
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Jul 31 23:40:55 2013 -0700

    kirby: pit: Fix up wakeup_need_reset
    
    In a previous commit the contents of wakeup_need_reset were removed because
    the GPIO it referred to wasn't connected to anything on pit. I didn't realize
    at that time that that could have been because we hadn't tried getting
    suspend/resume working on pit and hadn't updated that file. On snow, the GPIO
    is the recovery mode pin. This change updates pit to have the right GPIO,
    kirby to read that GPIO, and makes the comments for both pit and kirby more
    explicit and spells out the fact that this is the recovery mode GPIO.
    
    Having a check here at all may still be a holdover from snow that isn't
    applicable to pit or kirby, but since there is a parallel as far as the
    recovery mode GPIO we might as well make them match while waiting for more
    information.
    
    Change-Id: Ic1f3f605a0fddf89e8f5668c7a8df30bdfb91d94
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/64164
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>


See http://review.coreboot.org/4421 for details.

-gerrit



More information about the coreboot-gerrit mailing list