[coreboot-gerrit] Patch set updated for coreboot: 42c2afc arm: Don't use const pointers with the write functions

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 10:00:44 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4400

-gerrit

commit 42c2afcebc15a3efa543a0eb795a48bb8eb0887b
Author: Gabe Black <gabeblack at google.com>
Date:   Tue Jul 30 13:52:27 2013 -0700

    arm: Don't use const pointers with the write functions
    
    This functions are by definition changing the data pointed to by their
    arguments, so they shouldn't by const.
    
    Change-Id: Id29b3f76526aba463f8bb744f53101327f9c7bde
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/63777
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
---
 src/arch/armv7/include/arch/io.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/arch/armv7/include/arch/io.h b/src/arch/armv7/include/arch/io.h
index be1da51..e044090 100644
--- a/src/arch/armv7/include/arch/io.h
+++ b/src/arch/armv7/include/arch/io.h
@@ -45,21 +45,21 @@ static inline uint32_t read32(const void *addr)
 	return *(volatile uint32_t *)addr;
 }
 
-static inline void write8(uint8_t val, const void *addr)
+static inline void write8(uint8_t val, void *addr)
 {
 	dmb();
 	*(volatile uint8_t *)addr = val;
 	dmb();
 }
 
-static inline void write16(uint16_t val, const void *addr)
+static inline void write16(uint16_t val, void *addr)
 {
 	dmb();
 	*(volatile uint16_t *)addr = val;
 	dmb();
 }
 
-static inline void write32(uint32_t val, const void *addr)
+static inline void write32(uint32_t val, void *addr)
 {
 	dmb();
 	*(volatile uint32_t *)addr = val;



More information about the coreboot-gerrit mailing list