[coreboot-gerrit] Patch set updated for coreboot: 25eb7f5 pit: Get rid of the mostly unnecessary exynos5420.h

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 09:05:28 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4420

-gerrit

commit 25eb7f5e6c03f99574a9356b80910d9762ad83f4
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Jul 31 23:21:34 2013 -0700

    pit: Get rid of the mostly unnecessary exynos5420.h
    
    Like on kirby, this header had a single constant in it that was actually used.
    This change moves that constant inline and gets rid of the header file.
    
    Change-Id: Ibe380396f72fddb121fb6ceb3cee24f1b9a85738
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/64163
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/pit/exynos5420.h | 34 ----------------------------------
 src/mainboard/google/pit/mainboard.c  |  2 --
 src/mainboard/google/pit/romstage.c   |  4 +---
 3 files changed, 1 insertion(+), 39 deletions(-)

diff --git a/src/mainboard/google/pit/exynos5420.h b/src/mainboard/google/pit/exynos5420.h
deleted file mode 100644
index 21b704c..0000000
--- a/src/mainboard/google/pit/exynos5420.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2013 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/* I2C */
-#define I2C_0_SPEED 100000
-#define I2C_4_SPEED 1000000	/* 1MHz */
-#define I2C_SLAVE 0
-
-/* Voltages */
-#define VDD_ARM_MV 1300		// 1.3V
-#define VDD_INT_UV 1012500	// 1.0125V
-#define VDD_MIF_MV 1000		// 1.0V
-#define VDD_G3D_MV 1200		// 1.2V
-#define VDD_LDO2_MV 1500	// 1.5V
-#define VDD_LDO3_MV 1800	// 1.8V
-#define VDD_LDO5_MV 1800	// 1.8V
-#define VDD_LDO10_MV 1800	// 1.8V
-
diff --git a/src/mainboard/google/pit/mainboard.c b/src/mainboard/google/pit/mainboard.c
index 04010ac..cf84040 100644
--- a/src/mainboard/google/pit/mainboard.c
+++ b/src/mainboard/google/pit/mainboard.c
@@ -38,8 +38,6 @@
 #include <ec/google/chromeec/ec.h>
 #include <stdlib.h>
 
-#include "exynos5420.h"
-
 /* convenient shorthand (in MB) */
 #define DRAM_START	(CONFIG_SYS_SDRAM_BASE >> 20)
 #define DRAM_SIZE	CONFIG_DRAM_SIZE_MB
diff --git a/src/mainboard/google/pit/romstage.c b/src/mainboard/google/pit/romstage.c
index 255f292..c11f712 100644
--- a/src/mainboard/google/pit/romstage.c
+++ b/src/mainboard/google/pit/romstage.c
@@ -40,8 +40,6 @@
 #include <drivers/maxim/max77802/max77802.h>
 #include <device/i2c.h>
 
-#include "exynos5420.h"
-
 #define MMC0_GPIO_PIN	(58)
 
 struct pmic_write
@@ -89,7 +87,7 @@ static void setup_power(int is_resume)
 
 	/* Initialize I2C bus to configure PMIC. */
 	exynos_pinmux_i2c4();
-	i2c_init(4, I2C_4_SPEED, 0x00);
+	i2c_init(4, 1000000, 0x00); /* 1MHz */
 
 	printk(BIOS_DEBUG, "%s: Setting up PMIC...\n", __func__);
 



More information about the coreboot-gerrit mailing list