[coreboot-gerrit] Patch merged into coreboot/master: e20ab84 libpayload: Increase USB EHCI transfer timeout

gerrit at coreboot.org gerrit at coreboot.org
Sat Dec 21 07:39:20 CET 2013


the following patch was just integrated into master:
commit e20ab8478a4e6ff58a2f9ac7c62db9739e4c78d9
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Jul 23 12:45:18 2013 -0700

    libpayload: Increase USB EHCI transfer timeout
    
    The EHCI driver defines a maximum transfer timeout of two seconds. The
    comments state that during tests the maximum amount of required transfer
    time was for the SCSI TEST_UNIT_READY command on certain devices. We
    have now observed a USB device (Patriot Memory 13fe:3100) that can NAK
    this command for slightly more than two seconds. It will also completely
    fail if the timeout hits, since it gets confused by the subsequent CSW
    retry/recovery mechanism and starts producing babble errors. This patch
    increases the timeout to three seconds to circumvent this problem.
    
    To test, boot a Falco from a red-black RageXT USB stick.
    
    Change-Id: I3c4fef468fb16eacc5a487d76d025a78fb450e27
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/63095
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-by: Sameer Nanda <snanda at chromium.org>


See http://review.coreboot.org/4379 for details.

-gerrit



More information about the coreboot-gerrit mailing list