[coreboot-gerrit] Patch set updated for coreboot: dc3a536 lynxpoint: power management setup tweak

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 00:05:24 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4372

-gerrit

commit dc3a5368b364e94749e3a0fe304138620200cf20
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Jul 16 09:01:43 2013 -0700

    lynxpoint: power management setup tweak
    
    Updated from 161 ref code
    
    Change-Id: I3e07935fec1df21f14d97d165792fe54bf9e474c
    Reviewed-on: https://gerrit.chromium.org/gerrit/62128
    Tested-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Stefan Reinauer <reinauer at google.com>
    Commit-Queue: Duncan Laurie <dlaurie at chromium.org>
---
 src/southbridge/intel/lynxpoint/lpc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index b6e4e87..5d1bcdd 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -460,13 +460,12 @@ static void enable_lp_clock_gating(device_t dev)
 	 * RCBA + 0x2614[27:25,14:13,10,8] = 101,11,1,1
 	 * RCBA + 0x2614[23:16] = 0x20
 	 * RCBA + 0x2614[30:28] = 0x0
-	 * RCBA + 0x2614[26] = 1 (IF B2 STEP && 0:31.0 at 0xFA > 4)
+	 * RCBA + 0x2614[26] = 1 (IF 0:2.0 at 0x08 >= 0x0b)
 	 */
 	RCBA32_AND_OR(0x2614, 0x8bffffff, 0x0a206500);
 
 	/* Check for LPT-LP B2 stepping and 0:31.0 at 0xFA > 4 */
-	if (pch_silicon_revision() >= LPT_LP_STEP_B2 &&
-	    pci_read_config8(dev, 0xfa) > 4)
+	if (pci_read_config8(dev_find_slot(0, PCI_DEVFN(2, 0)), 0x8) >= 0x0b)
 		RCBA32_OR(0x2614, (1<<26));
 
 	RCBA32_OR(0x900, 0x0000031f);



More information about the coreboot-gerrit mailing list