[coreboot-gerrit] Patch set updated for coreboot: 680f98c Fix linking microcode with more than one microcode file

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Dec 12 22:34:00 CET 2013


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4500

-gerrit

commit 680f98c2ae0c9611000d2bac8e736128ad456774
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Sat Dec 7 18:57:02 2013 -0600

    Fix linking microcode with more than one microcode file
    
    When assembling microcode , the rule to link individual object files into
    one larger file only passed the first dependency to the linker. As a results
    only microcode from one object file would actually get linked. This is fixed
     by replacing $^ with $+ inside the make rule.
    
    Change-Id: I65c0565f2e03777af23e530c08d1241804ca19b1
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/cpu/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.inc
index 34ae53e..7cd9d5f 100644
--- a/src/cpu/Makefile.inc
+++ b/src/cpu/Makefile.inc
@@ -41,7 +41,7 @@ endif
 # final microcode file.
 $(obj)/cpu_microcode_blob.o: $$(cpu_microcode-objs)
 	@printf "    LD         $(subst $(obj)/,,$(@))\n"
-	$(LD) -static --entry=0 $< -o $@
+	$(LD) -static --entry=0 $+ -o $@
 
 # We have a lot of useless data in the large blob, and we are only interested in
 # the data section, so we only copy that part to the final microcode file



More information about the coreboot-gerrit mailing list