[coreboot-gerrit] Patch merged into coreboot/master: e0b621a HDA: Enable Mini-HDA and fix up PCH-HDA init

gerrit at coreboot.org gerrit at coreboot.org
Thu Dec 12 22:11:48 CET 2013


the following patch was just integrated into master:
commit e0b621a37d2b5b112d499f9803d3b2b755384a09
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Thu Jun 20 12:40:55 2013 -0700

    HDA: Enable Mini-HDA and fix up PCH-HDA init
    
    The SystemAgent contains a mini-hd audio controller at PCI 0:3.0
    which uses the same verb table init sequence as the southbridge.
    
    In order to avoid two copies of the verb table loading code I
    separated out the HDA verb table functions into a file that can
    be re-used and then added a minihd driver to the haswell northbridge.
    
    The minihd verb table is the same across devices so it can live
    within the minihd driver rather than needing to be specified in
    each separate mainboard.
    
    I also fixed up the driver for lynxpoint HDA by following the
    reference code.
    
    Without HDMI cable plugged in driver does not find any codec,
    and it does not seem to re-probe when HDMI is connected.  We may
    be missing kernel patches for this.
    
    hda-intel 0000:00:03.0: no codecs found!
    
    With a basic kernel patch to add 0x0a0c device ID to HDA driver
    and with HDMI cable connected it is much happier:
    
    snd_hda_intel 0000:00:03.0: irq 60 for MSI/MSI-X
    input: HDA Intel MID HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:03.0/sound/card0/input9
    snd_hda_intel 0000:00:1b.0: irq 61 for MSI/MSI-X
    input: HDA Intel PCH Mic as /devices/pci0000:00/0000:00:1b.0/sound/card1/input10
    input: HDA Intel PCH Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card1/input11
    
    Change-Id: Ifa587984be4fc2801704a0368b9cdf8379c2450e
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/59336
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/4318 for details.

-gerrit



More information about the coreboot-gerrit mailing list