[coreboot-gerrit] New patch to review for coreboot: fc39c32 cpu: Only ask for length and address of ucode when included in CBFS

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Dec 5 05:28:03 CET 2013


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4481

-gerrit

commit fc39c32051fbd44b757d52e6c2e5800a13f40acb
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Dec 4 22:05:15 2013 -0600

    cpu: Only ask for length and address of ucode when included in CBFS
    
    The original intention was to only run prompt for CPU_MICROCODE_CBFS_LOC
    and CPU_MICROCODE_CBFS_LEN when a microcode file was included in CBFS.
    This happens when either CPU_MICROCODE_CBFS_GENERATE or
    CPU_MICROCODE_CBFS_EXTERNAL is selected, however, Kconfig checked that
    against CPU_MICROCODE_IN_CBFS. The end result was that on length and
    location were always prompted, even when the user elected not to include
    any microcode.
    
    Instead, check CPU_MICROCODE_CBFS_NONE, which, when selected, means a
    microcode file will not be placed in CBFS.
    
    Change-Id: I9b61d022bcc879549e844bdfd5d5109554cc1a16
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/cpu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig
index 7317bcc..20be31e 100644
--- a/src/cpu/Kconfig
+++ b/src/cpu/Kconfig
@@ -162,12 +162,12 @@ config CPU_MICROCODE_FILE
 
 config CPU_MICROCODE_CBFS_LOC
 	  hex "Microcode address in CBFS"
-	  depends on CPU_MICROCODE_IN_CBFS
+	  depends on !CPU_MICROCODE_CBFS_NONE
 	  default 0
 
 config CPU_MICROCODE_CBFS_LEN
 	  hex "Microcode length in CBFS"
-	  depends on CPU_MICROCODE_IN_CBFS
+	  depends on !CPU_MICROCODE_CBFS_NONE
 	  default 0xC000
 	  help
 		The microcode needs a specific length to get correctly



More information about the coreboot-gerrit mailing list