[coreboot-gerrit] New patch to review for coreboot: cd07199 Slippy: remove unneeded code in i915io.c

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Dec 3 22:41:39 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4380

-gerrit

commit cd071994ea9136e4afbbfe3dc6bff434b471f8ec
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Tue Jul 16 17:56:20 2013 -0700

    Slippy: remove unneeded code in i915io.c
    
    This code is left over from what the VBIOS did; It is redundant.
    
    Change-Id: I321c867c81ec8b4d5e10f8b51b872cecb3082d97
    Signed-off-by: Ronald G. Minnich <rminnich at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/62290
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Furquan Shaikh <furquan at chromium.org>
    Tested-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/slippy/i915io.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/src/mainboard/google/slippy/i915io.c b/src/mainboard/google/slippy/i915io.c
index 21f5e6c..18e0480 100644
--- a/src/mainboard/google/slippy/i915io.c
+++ b/src/mainboard/google/slippy/i915io.c
@@ -40,28 +40,6 @@ void runio(struct intel_dp *dp)
 {
 	intel_dp_wait_panel_power_control(0xabcd0008);
 
-	/* replace with function to write to i2c; in this case, we're still
-	 * unsure of what these i2c sequences do
-	 */
-
-	auxout = 0<<31 /* i2c */|1<<30|0x0<<28/*W*/|0x50<<8|0x0|0x40005000;
-	unpack_aux(auxout, &msg[0], 4);
-	auxout = 0x00000000;
-	unpack_aux(auxout, &msg[4], 4);
-	intel_dp_aux_ch(dp, msg, 5, auxin, 0);
-
-	auxout = 0<<31 /* i2c */|0<<30|0x1<<28/*R*/|0x50<<8|0x3|0x10005003;
-	unpack_aux(auxout, &msg[0], 4);
-	intel_dp_aux_ch(dp, msg, 4, auxin, 3);
-	intel_dp_wait_panel_power_control(0xabcd0008);
-	auxout = 0<<31 /* i2c */|1<<30|0x0<<28/*W*/|0x50<<8|0x0|0x40005000;
-	unpack_aux(auxout, &msg[0], 4);
-	auxout = 0x04000000;
-	unpack_aux(auxout, &msg[4], 4);
-	intel_dp_aux_ch(dp, msg, 5, auxin, 0);
-	auxout = 0<<31 /* i2c */|0<<30|0x1<<28/*R*/|0x50<<8|0x3|0x10005003;
-	unpack_aux(auxout, &msg[0], 4);
-
 	/* vbios spins at this point. Some haswell weirdness? */
 	intel_dp_wait_panel_power_control(0xabcd0008);
 



More information about the coreboot-gerrit mailing list