[coreboot-gerrit] New patch to review for coreboot: 893bb48 falco: drive WLAN_DISABLE_L low in S3 and S5

[Stefan Reinauer (stefan.reinauer@coreboot.org)]

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4358

-gerrit

commit 893bb483999d9c73d7243bcdd357f32da3e86855
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Jul 10 09:04:47 2013 -0500

    falco: drive WLAN_DISABLE_L low in S3 and S5
    
    When the board is in S3 and S5 the WLAN_DISABLE_L signal
    can leak power into the WLAN power well since the GPIO
    controlling WLAN_DISABLE_L is in the suspend well. Therefore,
    drive WLAN_DISABLE_L low to avoid the power leak.
    
    Change-Id: I1a0df80dd47fdbd535aca7a9d49253794c480606
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/61421
---
 src/mainboard/google/falco/smihandler.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/mainboard/google/falco/smihandler.c b/src/mainboard/google/falco/smihandler.c
index 7b7dd69..52dd776 100644
--- a/src/mainboard/google/falco/smihandler.c
+++ b/src/mainboard/google/falco/smihandler.c
@@ -32,6 +32,9 @@
 #include <ec/google/chromeec/ec.h>
 #include "ec.h"
 
+/* GPIO46 controls the WLAN_DISABLE_L signal. */
+#define GPIO_WLAN_DISABLE_L 46
+
 int mainboard_io_trap_handler(int smif)
 {
 	switch (smif) {
@@ -98,6 +101,9 @@ void mainboard_smi_sleep(u8 slp_typ)
 		if (smm_get_gnvs()->s3u1 == 0)
 			google_chromeec_set_usb_charge_mode(
 				1, USB_CHARGE_MODE_DISABLED);
+
+		/* Prevent leak from standby rail to WLAN rail in S3. */
+		set_gpio(GPIO_WLAN_DISABLE_L, 0);
 		break;
 	case 5:
 		if (smm_get_gnvs()->s5u0 == 0)
@@ -106,6 +112,9 @@ void mainboard_smi_sleep(u8 slp_typ)
 		if (smm_get_gnvs()->s5u1 == 0)
 			google_chromeec_set_usb_charge_mode(
 				1, USB_CHARGE_MODE_DISABLED);
+
+		/* Prevent leak from standby rail to WLAN rail in S5. */
+		set_gpio(GPIO_WLAN_DISABLE_L, 0);
 		break;
 	}