[coreboot-gerrit] Patch merged into coreboot/master: ff906f4 Make elog_shrink not depend on having seperate memory/flash descriptors.

gerrit at coreboot.org gerrit at coreboot.org
Mon Dec 2 15:16:33 CET 2013


the following patch was just integrated into master:
commit ff906f45d591fecf0a1e89e55004385ba7d0e889
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Apr 24 03:16:21 2013 -0700

    Make elog_shrink not depend on having seperate memory/flash descriptors.
    
    The way elog_shrink currently works is that it completely clears the data in
    the flash/flash descriptor and then recreates it using the part of the log
    it's going to keep as stored in the memory descriptor. That scheme depends on
    there being to independent copies of the log.
    
    This change reworks elog_shrink so that it moves the data it wants to keep
    within a single descriptor and then propogates it to the other and to flash
    intact. This way, when one of the descriptors goes away, all we have to do is
    remove the code that would update it.
    
    Built and booted into ChromeOS on Link. Ran mosys eventlog list. Added
    2000 events to the log and ran mosys eventlog list again. Echoed a 1 into
    /sys/firmware/gsmi/clear_eventlog and ran mosys eventlog list.
    BRANCH=None
    
    Change-Id: I50d77a4f00ea3c6b3e0ec8996dab1a3b31580205
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/49305
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>


See http://review.coreboot.org/4240 for details.

-gerrit



More information about the coreboot-gerrit mailing list