[coreboot-gerrit] Patch merged into coreboot/master: 1ae7d47 AMD Fam15tn boards: BiosCallOuts.c: Remove board name from `CodecTableList`

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 15 20:34:28 CEST 2013

the following patch was just integrated into master:
commit 1ae7d475a82327b6a0f26f9ee34308a85c437b24
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 4 18:41:54 2013 +0200

    AMD Fam15tn boards: BiosCallOuts.c: Remove board name from `CodecTableList`
    The board name in that variable name is not necessary, as it is not board
    dependent, that means using the file as a template for making a new
    coreboot port for another motherboard the variable does not need to be
    changed, and just increases the code differences between AMD Parmer,
    AMD Thather and ASUS F2A85-M. So use a generic name.
    The same was done for AMD Persimmon (and inherited by the LiPPERT
    FrontRunner/Toucan-AF) in the following commit.
        commit 5e70766f14253f53190ddd49a544460c6bc1e528
        Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
        Date:   Tue Feb 26 15:56:11 2013 +0100
            AMD Fam14 boards: reduce unnecessary differences, 2nd attempt
            Reviewed-on: http://review.coreboot.org/2529
    The board name is *not* removed from the `CODEC_ENTRY` variable name as
    the verb table not only depends on the codec but also on the board [1].
    Having the board name in the variable name is a good indicator that the
    pin configuration needs to be adapted when taking this file as a template
    for a new port. If it was board independent, a default chip configuration
    could be used and shared between all boards, which is unfortunately not
    the case.
    [1] Unfortunately I was not able to find Jens’ comment in my mail archive
        and in the Gerrit Web interface. Not sure where it is, but I am sure
        he made that comment.
    Change-Id: I440a306cf4ff0a5b1b61d1983d70c66d129904d0
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3199
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

See http://review.coreboot.org/3199 for details.


More information about the coreboot-gerrit mailing list