[coreboot-gerrit] Patch set updated for coreboot: cedf48e Google/Snow: Remove duplicated SPI1 initialization in bootblock.

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Tue Apr 30 20:26:26 CEST 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3147


commit cedf48e463e287f647b13d2de1c1fbda7199f0ea
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Apr 30 16:11:32 2013 +0800

    Google/Snow: Remove duplicated SPI1 initialization in bootblock.
    The firmware media source (SPI1) is already initialized by Exynos iROM.
    There is no need to do it again.
    Verified by building and booting Google/Snow successfully.
    Change-Id: I89390506aa825397c0d7e52ad7503f1cb808f7db
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
 src/mainboard/google/snow/bootblock.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c
index 1746290..4a78946 100644
--- a/src/mainboard/google/snow/bootblock.c
+++ b/src/mainboard/google/snow/bootblock.c
@@ -40,8 +40,13 @@ void bootblock_mainboard_init(void)
 			 * We want to do this as early as we can.
-			exynos_pinmux_config(PERIPH_ID_SPI1, PINMUX_FLAG_NONE);
+	/* For most ARM systems, we have to initialize firmware media source
+	 * (ex, SPI, SD/MMC, or eMMC) now; but for Exynos platform, that is
+	 * already handled by iROM so there's no need to setup again.
+	 */

More information about the coreboot-gerrit mailing list