[coreboot-gerrit] Patch set updated for coreboot: e023cfe Google/Snow: Remove unnecessary serial console init code.

Hung-Te Lin (hungte@chromium.org) gerrit at coreboot.org
Tue Apr 30 09:43:29 CEST 2013

Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3150


commit e023cfef20d1ca5298aeb0f2da384bb63fa263d3
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Apr 30 15:31:48 2013 +0800

    Google/Snow: Remove unnecessary serial console init code.
    The "console_init" does initialize UART driver (which will setup peripheral and
    pinmux) and print starting message. Duplicated initialization can be removed.
    Also, console_init (from console.c) is always linked to bootblock (and will do
    nothing if CONFIG_EARLY_CONSOLE is not defined) so it's safe to remove #ifdef.
    Verified by building and booting on Google/Snow, with and without
    Change-Id: I0c6b4d4eb1a4e81af0f65bcb032978dfb945c63d
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
 src/mainboard/google/snow/bootblock.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c
index 09edbad..1746290 100644
--- a/src/mainboard/google/snow/bootblock.c
+++ b/src/mainboard/google/snow/bootblock.c
@@ -43,9 +43,5 @@ void bootblock_mainboard_init(void)
 			exynos_pinmux_config(PERIPH_ID_SPI1, PINMUX_FLAG_NONE);
-	exynos_pinmux_config(PERIPH_ID_UART3, PINMUX_FLAG_NONE);
-	printk(BIOS_INFO, "\n\n\n%s: UART initialized\n", __func__);

More information about the coreboot-gerrit mailing list