[coreboot-gerrit] Patch merged into coreboot/master: bf92b19 Google/Snow: Temporary fix for resume failure.

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 30 05:49:43 CEST 2013

the following patch was just integrated into master:
commit bf92b19b2a234d63d88fea6bd55ad83361e18574
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Mon Apr 29 22:11:22 2013 +0800

    Google/Snow: Temporary fix for resume failure.
    The DDR3 memory initialization (with "mem_reset" set on normal boot) will cause
    resume to be unstable, especially when X is running. System may show X screen
    for few seconds, then crash randomly and unable to recover - although text
    console may still work for a while.  Probably caused by corrupted memory pages.
    'mem_reset' (which refers to RESET# in DDR3 spec) should be enabled according
    to DDR3 spec. But it seems that on Exynos 5, memory can be initialized without
    setting mem_reset for both normal boot and resume - at least no known failure
    cases are found yet.  So this can be a temporary workaround.
    Verified by booting a Google/Snow device with X Window and ChromeOS, entering
    browser session with fancy web pages, closing LID to suspend for 5 seconds, then
    re-opening to resume.  Suspend/resume worked as expected.
    Also tried the "suspend_stress_test" with X running and finished 100 iterations
    of suspend/resume test without failure.
    Change-Id: I7185b362ce8b545fe77b35a552245736c89d465e
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/3148
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Mon Apr 29 20:02:13 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Tue Apr 30 05:49:42 2013, giving +2
See http://review.coreboot.org/3148 for details.


More information about the coreboot-gerrit mailing list