[coreboot-gerrit] Patch set updated for coreboot: 2c8cfbf AMD Hudson A55E: Remove GEC firmware blob kconfig prompt

[Bruce Griffith (Bruce.Griffith@se-eng.com)]

Bruce Griffith (Bruce.Griffith at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3127

-gerrit

commit 2c8cfbf9d26f5910aab86b9ee7bb9fc8fa1b702d
Author: Bruce Griffith <Bruce.Griffith at se-eng.com>
Date:   Tue Apr 23 14:31:55 2013 -0600

    AMD Hudson A55E: Remove GEC firmware blob kconfig prompt
    
    The "gigabit ethernet controller" (GEC) block was added to AMD
    Hudson A55E to integrate ethernet capabilities into an AMD
    southbridge.
    
    The GEC is designed to work with B50610 and B50610M gigabit PHY
    chips from Broadcom.  These parts may not be generally available
    in small quantities for embedded development.
    
    The GEC block requires an opaque firmware blob to function.  The
    GEC blob is controlled by AMD and Broadcom and is not available
    from coreboot.org.
    
    This change removes GEC support from AMD Parmer and AMD Thatcher
    mainboards since these boards do not have the Broadcom PHY.
    
    AMD has requested that the GEC be hidden for Hudson FCH since
    the PHY parts are not generally available.  This Kconfig option
    can make it appear that this is a viable and supported way to
    add Ethernet to an embedded board.  It is possible to use the
    Hudson GEC block with other PHYs, but this requires development
    of a custom GEC blob and a custom Ethernet driver.  A custom GEC
    blob has been developed for a Micrel PHY, but there is no
    accompanying driver.
    
    Change-Id: I7a7bf4d41e453390ecf987c9c45ef2434fc1f1a3
    Signed-off-by: Bruce Griffith <Bruce.Griffith at se-eng.com>
---
 src/mainboard/amd/parmer/BiosCallOuts.c   | 2 +-
 src/mainboard/amd/parmer/agesawrapper.c   | 1 -
 src/mainboard/amd/thatcher/BiosCallOuts.c | 2 +-
 src/mainboard/amd/thatcher/agesawrapper.c | 1 -
 src/southbridge/amd/agesa/hudson/Kconfig  | 5 +++--
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c
index 924ea19..c77d78d 100644
--- a/src/mainboard/amd/parmer/BiosCallOuts.c
+++ b/src/mainboard/amd/parmer/BiosCallOuts.c
@@ -269,7 +269,7 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
  * Fch Oem setting callback
  *
  *  Configure platform specific Hudson device,
- *   such Azalia, SATA, GEC, IMC etc.
+ *   such Azalia, SATA, IMC etc.
  */
 AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 {
diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c
index aecd1ea..a81a997 100644
--- a/src/mainboard/amd/parmer/agesawrapper.c
+++ b/src/mainboard/amd/parmer/agesawrapper.c
@@ -557,7 +557,6 @@ STATIC VOID s3_resume_init_data(FCH_DATA_BLOCK *FchParams)
 	FchParams->Sata.SataRaidSsid           = UserOptions.FchBldCfg->CfgSataRaidSsid;
 	FchParams->Sata.SataAhciSsid           = UserOptions.FchBldCfg->CfgSataAhciSsid;
 	FchParams->Sata.SataIdeSsid            = UserOptions.FchBldCfg->CfgSataIdeSsid;
-	FchParams->Gec.GecShadowRomBase        = UserOptions.FchBldCfg->CfgGecShadowRomBase;
 	FchParams->Spi.RomBaseAddress          = UserOptions.FchBldCfg->CfgSpiRomBaseAddress;
 	FchParams->Sd.SdSsid                   = UserOptions.FchBldCfg->CfgSdSsid;
 	FchParams->Spi.LpcSsid                 = UserOptions.FchBldCfg->CfgLpcSsid;
diff --git a/src/mainboard/amd/thatcher/BiosCallOuts.c b/src/mainboard/amd/thatcher/BiosCallOuts.c
index e0af994..9a3f61c 100644
--- a/src/mainboard/amd/thatcher/BiosCallOuts.c
+++ b/src/mainboard/amd/thatcher/BiosCallOuts.c
@@ -269,7 +269,7 @@ static void oem_fan_control(FCH_DATA_BLOCK *FchParams)
  * Fch Oem setting callback
  *
  *  Configure platform specific Hudson device,
- *   such Azalia, SATA, GEC, IMC etc.
+ *   such Azalia, SATA, IMC etc.
  */
 AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 {
diff --git a/src/mainboard/amd/thatcher/agesawrapper.c b/src/mainboard/amd/thatcher/agesawrapper.c
index df45148..f7577fd 100644
--- a/src/mainboard/amd/thatcher/agesawrapper.c
+++ b/src/mainboard/amd/thatcher/agesawrapper.c
@@ -559,7 +559,6 @@ STATIC VOID s3_resume_init_data(FCH_DATA_BLOCK *FchParams)
 	FchParams->Sata.SataRaidSsid           = UserOptions.FchBldCfg->CfgSataRaidSsid;
 	FchParams->Sata.SataAhciSsid           = UserOptions.FchBldCfg->CfgSataAhciSsid;
 	FchParams->Sata.SataIdeSsid            = UserOptions.FchBldCfg->CfgSataIdeSsid;
-	FchParams->Gec.GecShadowRomBase        = UserOptions.FchBldCfg->CfgGecShadowRomBase;
 	FchParams->Spi.RomBaseAddress          = UserOptions.FchBldCfg->CfgSpiRomBaseAddress;
 	FchParams->Sd.SdSsid                   = UserOptions.FchBldCfg->CfgSdSsid;
 	FchParams->Spi.LpcSsid                 = UserOptions.FchBldCfg->CfgLpcSsid;
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index 52692f9..3e58563 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -56,10 +56,11 @@ config HUDSON_IMC_FWM
 	  Add Hudson 2/3/4 IMC Firmware to support the onboard fan control
 
 config HUDSON_GEC_FWM
-	bool "Add gec firmware"
+	bool
 	default n
         help
-	  Add Hudson 2/3/4 GEC Firmware
+	  Add Hudson 2/3/4 GEC Firmware to support the onboard gigabit Ethernet MAC.
+	  Must be connected to a Broadcom B50610 or B50610M PHY on the motherboard.
 
 config HUDSON_XHCI_FWM_FILE
         string "XHCI firmware path and filename"