[coreboot-gerrit] Patch set updated for coreboot: 59455b1 AMD CIMx SB800: Remove unused function `get_sbdn()`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Apr 22 22:09:11 CEST 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3119

-gerrit

commit 59455b19a2765ed878570be0f5e94d3e132fc391
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Apr 19 10:23:03 2013 +0200

    AMD CIMx SB800: Remove unused function `get_sbdn()`
    
    No SB800 based board uses the function `get_sbdn()`, which
    was probably copied from SB700 code. So remove it.
    
    Change-Id: I85fe3db0abf2648b6eb7a659f2112d130f856afa
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/southbridge/amd/cimx/sb800/early.c   | 22 ----------------------
 src/southbridge/amd/cimx/sb800/sb_cimx.h |  8 --------
 2 files changed, 30 deletions(-)

diff --git a/src/southbridge/amd/cimx/sb800/early.c b/src/southbridge/amd/cimx/sb800/early.c
index 83087f5..dad215f 100644
--- a/src/southbridge/amd/cimx/sb800/early.c
+++ b/src/southbridge/amd/cimx/sb800/early.c
@@ -26,28 +26,6 @@
 #include "cfg.h"		/*sb800_cimx_config*/
 #include "cbmem.h"
 
-#if CONFIG_RAMINIT_SYSINFO
-/**
- * @brief Get SouthBridge device number
- * @param[in] bus target bus number
- * @return southbridge device number
- */
-u32 get_sbdn(u32 bus)
-{
-	device_t dev;
-
-	printk(BIOS_DEBUG, "SB800 - %s - %s - Start.\n", __FILE__, __func__);
-	//dev = PCI_DEV(bus, 0x14, 0);
-	dev = pci_locate_device_on_bus(
-			PCI_ID(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SB800_SM),
-			bus);
-
-	printk(BIOS_DEBUG, "SB800 - %s - %s - End.\n", __FILE__, __func__);
-	return (dev >> 15) & 0x1f;
-}
-#endif
-
-
 /**
  * @brief South Bridge CIMx romstage entry,
  *        wrapper of sbPowerOnInit entry point.
diff --git a/src/southbridge/amd/cimx/sb800/sb_cimx.h b/src/southbridge/amd/cimx/sb800/sb_cimx.h
index 3bec5d8..f07b0e0 100644
--- a/src/southbridge/amd/cimx/sb800/sb_cimx.h
+++ b/src/southbridge/amd/cimx/sb800/sb_cimx.h
@@ -40,12 +40,4 @@ int acpi_is_wakeup_early(void);
  */
 void sb800_clk_output_48Mhz(void);
 
-#if CONFIG_RAMINIT_SYSINFO
-/**
- * @brief Get SouthBridge device number, called by finalize_node_setup()
- * @param[in] bus target bus number
- * @return southbridge device number
- */
-u32 get_sbdn(u32 bus);
-#endif
 #endif



More information about the coreboot-gerrit mailing list