[coreboot-gerrit] Patch merged into coreboot/master: 6974396 AMD SB800 based boards: Use `#include <sb_cimx.h>` instead of `"sb_cimx.h"`

gerrit at coreboot.org gerrit at coreboot.org
Sat Apr 20 18:57:20 CEST 2013

the following patch was just integrated into master:
commit 69743962617b9de1a0263dc372bd9116671b5025
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Apr 19 10:05:57 2013 +0200

    AMD SB800 based boards: Use `#include <sb_cimx.h>` instead of `"sb_cimx.h"`
    Due to
        $ more src/southbridge/amd/cimx/sb800/Makefile.inc
        romstage-y += cfg.c
        romstage-y += early.c
        romstage-y += smbus.c
        ramstage-y += cfg.c
        ramstage-y += late.c
    `src/southbridge/amd/cimx/sb800/` is passed with the switch `-I` to
    the compiler, where it is also going to find the header file
    `sb_cimx.h`. Therefore use `#include <sb_cimx>` everywhere, which is
    what some AMD SB800 based boards already do.
    The only effect is, that the compiler will not needlessly look into
    directories which do not contain the header file [1].
    The following command was used for the replacement.
        $ git grep -l sb_cimx.h src/mainboard/ | xargs sed -i 's/#include "sb_cimx.h"/#include <sb_cimx.h>/'
    [1] http://gcc.gnu.org/onlinedocs/cpp/Search-Path.html
    Change-Id: I96ab34bac1524e6c38c85dfe9d99cb6ef55e6d7c
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3118
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Sat Apr 20 05:12:11 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Sat Apr 20 18:57:19 2013, giving +2
See http://review.coreboot.org/3118 for details.


More information about the coreboot-gerrit mailing list