[coreboot-gerrit] Patch merged into coreboot/master: 1fb11d1 armv7/exynos5250: Deprecate sdelay in favor of udelay

gerrit at coreboot.org gerrit at coreboot.org
Wed Apr 17 23:06:41 CEST 2013

the following patch was just integrated into master:
commit 1fb11d105b4cc0d424884a08814f65e73d36504a
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Apr 12 15:11:05 2013 -0700

    armv7/exynos5250: Deprecate sdelay in favor of udelay
    This gets rid of the clock-tick based sdelay in favor of udelay().
    udelay() is more consistent and easier to work with, and this allows
    us to carry one less variation of timers (and headers and sources...).
    Every 1 unit in the sdelay() argument was assumed to cause a delay of
    2 clock ticks (@1.7GHz). So the conversion factor is roughly:
    sdelay(N) = udelay(((N * 2) / 1.7 * 10^9) * 10^6)
              = udelay((N * 2) / (1.7 * 10^3))
    The sdelay() periods used were:
    sdelay(100) --> udelay(1)
    sdelay(0x10000) --> udelay(78) (rounded up to udelay(100))
    There was one instance of sdelay(10000), which looked like sort of a
    typo since sdelay(0x10000) was used elsewhere. sdelay(10000) should
    approximate to about 12us, so we'll stick with that for now and leave
    a note.
    Change-Id: I5e7407865ceafa701eea1d613bbe50cf4734f33e
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/3079
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Tue Apr 16 19:43:32 2013, giving +1
Reviewed-By: David Hendricks <dhendrix at chromium.org> at Wed Apr 17 00:19:13 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Apr 17 23:06:40 2013, giving +2
See http://review.coreboot.org/3079 for details.


More information about the coreboot-gerrit mailing list