[coreboot-gerrit] New patch to review for coreboot: 9c21202 AMD CIMx SB800: Kconfig: Add more information about SATA modes

[Paul Menzel (paulepanter@users.sourceforge.net)]

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3101

-gerrit

commit 9c212029eeb1f830ab8716ebff5da3517ce5a8e4
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Apr 16 13:09:40 2013 +0200

    AMD CIMx SB800: Kconfig: Add more information about SATA modes
    
    At least the Linux kernel is setting up the SATA controller to AHCI
    mode even if coreboot sets it to IDE (NATIVE) mode.
    
        $ dmesg
        […]
        [    0.172251] pci 0000:00:11.0: [1002:4390] type 0 class 0x000101
        [    0.172279] pci 0000:00:11.0: reg 10: [io  0x1410-0x1417]
        [    0.172294] pci 0000:00:11.0: reg 14: [io  0x1420-0x1423]
        [    0.172309] pci 0000:00:11.0: reg 18: [io  0x1418-0x141f]
        [    0.172323] pci 0000:00:11.0: reg 1c: [io  0x1424-0x1427]
        [    0.172338] pci 0000:00:11.0: reg 20: [io  0x1400-0x140f]
        [    0.172353] pci 0000:00:11.0: reg 24: [mem 0xf004b000-0xf004b3ff]
        [    0.172382] pci 0000:00:11.0: set SATA to AHCI mode
        […]
        [    1.127727] calling  ahci_init+0x0/0x1000 [ahci] @ 72
        [    1.177072] ahci 0000:00:11.0: version 3.0
        [    1.177353] ahci 0000:00:11.0: AHCI 0001.0200 32 slots 6 ports 6 Gbps 0x3f impl SATA mode
        [    1.177360] ahci 0000:00:11.0: flags: 64bit ncq sntf ilck led clo pmp pio slum part
        [    1.179783] scsi0 : ahci
        [    1.180073] scsi1 : ahci
        [    1.180228] scsi2 : ahci
        [    1.180406] scsi3 : ahci
        [    1.180525] scsi4 : ahci
        [    1.180917] scsi5 : ahci
        [    1.181208] ata1: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b100 irq 19
        [    1.181215] ata2: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b180 irq 19
        [    1.181221] ata3: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b200 irq 19
        [    1.181226] ata4: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b280 irq 19
        [    1.181232] ata5: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b300 irq 19
        [    1.181238] ata6: SATA max UDMA/133 abar m1024 at 0xf004b000 port 0xf004b380 irq 19
        [    1.181366] initcall ahci_init+0x0/0x1000 [ahci] returned 0 after 52315 usecs
        […]
        $ lspci -vvv
        […]
        00:11.0 SATA controller: Advanced Micro Devices [AMD] nee ATI SB7x0/SB8x0/SB9x0 SATA Controller [IDE mode] (rev 40) (prog-if 01 [AHCI 1.0])
        […]
    
    Clarify the above in the Kconfig description.
    
    Change-Id: I5b2b8d4de42d44db5d36aaace16b1c534a0c17ec
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/southbridge/amd/cimx/sb800/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/amd/cimx/sb800/Kconfig b/src/southbridge/amd/cimx/sb800/Kconfig
index 554d8c7..0555ad5 100644
--- a/src/southbridge/amd/cimx/sb800/Kconfig
+++ b/src/southbridge/amd/cimx/sb800/Kconfig
@@ -48,8 +48,11 @@ choice
 	prompt "SATA Mode"
 	default SB800_SATA_AHCI
 	help
-	  Select the mode in which SATA should be driven. NATIVE AHCI, or RAID.
-	  The default is AHCI.
+	  Select the mode in which the SATA controller should be driven: NATIVE, AHCI, or RAID.
+
+	  Note that most operating systems are going to set up the SATA controller to AHCI mode even when configured to NATIVE mode. So the only difference in user experience is going to be during the payload phase.
+
+	  The default mode is AHCI.
 
 config SB800_SATA_IDE
 	bool "NATIVE"