[coreboot-gerrit] New patch to review for coreboot: 2d74384 snow: Fix some comments in chromeos.c.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Apr 16 06:01:19 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3091

-gerrit

commit 2d74384aa780c8078c4c0c991312017059a2db10
Author: Gabe Black <gabeblack at chromium.org>
Date:   Mon Apr 15 16:25:02 2013 -0700

    snow: Fix some comments in chromeos.c.
    
    The comment about the lid switch was left over from when this file was copied
    from another board and was incorrect. Also fixed a capitalization
    inconsistency.
    
    Change-Id: Icefd19047971e13c08f615578e4a181e82a2997f
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/snow/chromeos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index 015b71e..e74df6d 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -52,7 +52,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 	gpio_pt1 = (struct exynos5_gpio_part1 *)EXYNOS5_GPIO_PART1_BASE;
 	gpio_pt2 = (struct exynos5_gpio_part2 *)EXYNOS5_GPIO_PART2_BASE;
 
-	/* Write Protect: active Low */
+	/* Write Protect: active low */
 	gpios->gpios[0].port = EXYNOS5_GPD1;
 	gpios->gpios[0].polarity = ACTIVE_LOW;
 	gpios->gpios[0].value = s5p_gpio_get_value(&gpio_pt1->d1, WP_GPIO);
@@ -65,7 +65,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 	gpios->gpios[1].value = s5p_gpio_get_value(&gpio_pt1->y1, FORCE_RECOVERY_MODE);
 	strncpy((char *)gpios->gpios[1].name,"recovery", GPIO_MAX_NAME_LENGTH);
 
-	/* Lid: the "switch" comes from the EC */
+	/* Lid: active high */
 	gpios->gpios[2].port = EXYNOS5_GPX3;
 	gpios->gpios[2].polarity = ACTIVE_HIGH;
 	gpios->gpios[2].value = s5p_gpio_get_value(&gpio_pt2->x3, LID_OPEN);



More information about the coreboot-gerrit mailing list