[coreboot-gerrit] Patch merged into coreboot/master: 07e0f1b AMD AGESA: Fix argument list for `PCIE_DDI_DATA_INITIALIZER` in comments

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 16 00:14:16 CEST 2013

the following patch was just integrated into master:
commit 07e0f1bf1a2781102e6f6a242a7a97944b0f3ba0
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Apr 13 15:58:03 2013 +0200

    AMD AGESA: Fix argument list for `PCIE_DDI_DATA_INITIALIZER` in comments
    When looking into possible reasons for a proposed revert [1], I noticed
    that the comments use four arguments for `PCIE_DDI_DATA_INITIALIZER`,
    but the actual definition only uses three.
        $ git grep -A1 PCIE_DDI_DATA_INITIALIZER # manually squeeze whitespace in output
        src/vendorcode/amd/agesa/f10/AGESA.h:#define  PCIE_DDI_DATA_INITIALIZER(mConnectorType, mAuxIndex, mHpdIndex ) \
        src/vendorcode/amd/agesa/f10/AGESA.h-{mConnectorType, mAuxIndex, mHpdIndex}
        src/vendorcode/amd/agesa/f10/AGESA.h:   *      PCIE_DDI_DATA_INITIALIZER (ConnectorType
        src/vendorcode/amd/agesa/f10/AGESA.h-   *    },
        src/vendorcode/amd/agesa/f10/AGESA.h:   *      PCIE_DDI_DATA_INITIALIZER (ConnectorType
        src/vendorcode/amd/agesa/f10/AGESA.h-   *    }
    So remove the fourth argument in the comments. Luckily the compiler,
    at least gcc, warns about a wrong number of arguments, and therefore
    no incorrect code resulted from the wrong documentation.
    [1] http://review.coreboot.org/#/c/3077/
    Change-Id: I3e5a02c66a23af1eb2d86be8dbc7aaa3e5cea05e
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3080
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Mon Apr 15 13:06:59 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Tue Apr 16 00:14:11 2013, giving +2
See http://review.coreboot.org/3080 for details.


More information about the coreboot-gerrit mailing list