[coreboot-gerrit] Patch merged into coreboot/master: 8764b0e Fam14 DSDT: Also return for unrecognized UUID in _OSC

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 15 23:42:36 CEST 2013


the following patch was just integrated into master:
commit 8764b0e1c03c6934ebefd47fbe4dc26069911f3d
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Thu Apr 4 16:05:11 2013 -0600

    Fam14 DSDT: Also return for unrecognized UUID in _OSC
    
    Fixing warnings introduced by the following patches:
    http://review.coreboot.org/#/c/2684/
    http://review.coreboot.org/#/c/2739/
    http://review.coreboot.org/#/c/2714/
    
    These patches were meant to fix the dmesg warning about
    the OSC method not granting control appropriately.  These
    patches then introduced warnings during the coreboot build
    process which were missed during the patch submission
    process.  These warnings are below:
    
    	Intel ACPI Component Architecture
    	ASL Optimizing Compiler version 20100528 [Oct 15 2010]
    	Copyright (c) 2000 - 2010 Intel Corporation
    	Supports ACPI Specification Revision 4.0a
    
    		dsdt.ramstage.asl  1143:    Method(_OSC,4)
    		Warning  1088 -                       ^ Not all control paths return a value (_OSC)
    
    		dsdt.ramstage.asl  1143:    Method(_OSC,4)
    		Warning  1081 -                       ^ Reserved method must return a value (Buffer required for _OSC)
    
    	ASL Input:  dsdt.ramstage.asl - 1724 lines, 34917 bytes, 889 keywords
    	AML Output: dsdt.ramstage.aml - 10470 bytes, 409 named objects, 480 executable opcodes
    
    	Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 494 Optimizations
    
    This patch gives the following compilation status:
    
    	Intel ACPI Component Architecture
    	ASL Optimizing Compiler version 20100528 [Oct  1 2012]
    	Copyright (c) 2000 - 2010 Intel Corporation
    	Supports ACPI Specification Revision 4.0a
    
    	ASL Input:  dsdt.ramstage.asl - 1732 lines, 33295 bytes, 941 keywords
    	AML Output: dsdt.ramstage.aml - 10152 bytes, 406 named objects, 535 executable opcodes
    
    	Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 432 Optimizations
    
    The fix is simply adding an Else statement to the If which checks
    for the proper UUID.  This way, all outcomes will return a full
    control package.  This patch has no effect on the dmesg output.
    
    Change-Id: I8fa246400310b26679ffa3aa278069d2e9507160
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
    Reviewed-on: http://review.coreboot.org/3052
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Apr 10 21:54:20 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Mon Apr 15 23:42:34 2013, giving +2
See http://review.coreboot.org/3052 for details.

-gerrit



More information about the coreboot-gerrit mailing list