[coreboot-gerrit] Patch merged into coreboot/master: 15a1fd1 inteltool: Use portable type `uint64_t` instead of `u64`

gerrit at coreboot.org gerrit at coreboot.org
Sun Apr 14 23:00:36 CEST 2013

the following patch was just integrated into master:
commit 15a1fd1db9dd93004f808badcb15ca635177def6
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Apr 14 13:00:22 2013 +0200

    inteltool: Use portable type `uint64_t` instead of `u64`
    In [1] Idwer Vollering noted, that the type `u64` is not portable so
    on his FreeBSD system, the following warning is shown.
        $ clang -O2 -Wall -W -I/usr/local/include   -c -o amb.o amb.c
        amb.c:441:22: error: use of undeclared identifier 'u64'
                        ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) |
    The type `uint64_t` seems to be defined also on FreeBSD, so using this
    fixes the warning.
    Note, this warning is not reproducable with Debian Sid/unstable for
    example. I have no idea why though.
    [1] http://review.coreboot.org/#/c/3015/
    Change-Id: Ic22f4371114b68ae8221d84a01fef6888d43f365
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3086
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Sun Apr 14 15:17:24 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Sun Apr 14 23:00:35 2013, giving +2
See http://review.coreboot.org/3086 for details.


More information about the coreboot-gerrit mailing list