[coreboot-gerrit] New patch to review for coreboot: 741b0b3 inteltool: Use portable type `uint64_t` instead of `u64`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Apr 14 14:35:35 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3086


commit 741b0b37241f5be84e9066bb51ebf85447b8ee23
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Apr 14 13:00:22 2013 +0200

    inteltool: Use portable type `uint64_t` instead of `u64`
    In [1] Idwer Vollering noted, that the type `u64` is not portable so
    on his FreeBSD system, the following warning is shown.
        $ clang -O2 -Wall -W -I/usr/local/include   -c -o amb.o amb.c
        amb.c:441:22: error: use of undeclared identifier 'u64'
                        ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) |
    The type `uint64_t` seems to be defined also on FreeBSD, so using this
    fixes the warning.
    Note, this warning is not reproducable with Debian Sid/unstable for
    example. I have no idea why though.
    [1] http://review.coreboot.org/#/c/3015/
    Change-Id: Ic22f4371114b68ae8221d84a01fef6888d43f365
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 util/inteltool/amb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/inteltool/amb.c b/util/inteltool/amb.c
index a1761ee..13397db 100644
--- a/util/inteltool/amb.c
+++ b/util/inteltool/amb.c
@@ -438,7 +438,7 @@ int print_ambs(struct pci_dev *dev, struct pci_access *pacc)
 			return 1;
-		ambconfig_phys = ((u64)pci_read_long(dev16, 0x4c) << 32) |
+		ambconfig_phys = ((uint64_t)pci_read_long(dev16, 0x4c) << 32) |
 			pci_read_long(dev16, 0x48);
 		max_channel = pci_read_byte(dev16, 0x56)/max_branch;

More information about the coreboot-gerrit mailing list