[coreboot-gerrit] Patch set updated for coreboot: 72683aa ARM: Unmask aborts very early in the bootblock.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Thu Apr 11 02:49:06 CEST 2013

Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3065


commit 72683aac9c82dd4535d07864b2f364d9db9bb53d
Author: Gabe Black <gabeblack at chromium.org>
Date:   Wed Apr 10 14:32:56 2013 -0700

    ARM: Unmask aborts very early in the bootblock.
    It's better to recognize aborts when they occur than to mask them to
    discover them later without knowing where they actually came from.
    Change-Id: Ic8f5321415f411afac94b5ef9dd440790df6d82c
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
 src/arch/armv7/bootblock.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/arch/armv7/bootblock.inc b/src/arch/armv7/bootblock.inc
index faf5475..8db31b4 100644
--- a/src/arch/armv7/bootblock.inc
+++ b/src/arch/armv7/bootblock.inc
@@ -53,11 +53,14 @@ _cbfs_master_header:
-	 * set the cpu to SVC32 mode
+	 * Set the cpu to SVC32 mode and unmask aborts. Aborts might happen
+	 * before logging is turned on and may crash the machine, but at least
+	 * the problem will show up near the code that causes it.
 	mrs	r0, cpsr
 	bic	r0, r0, #0x1f
 	orr	r0, r0, #0xd3
+	bic	r0, r0, #0x100
 	msr	cpsr_cxsf,r0

More information about the coreboot-gerrit mailing list