[coreboot-gerrit] Patch merged into coreboot/master: b959fbb exynos5: Re-factor I2C code

gerrit at coreboot.org gerrit at coreboot.org
Wed Apr 10 00:01:03 CEST 2013

the following patch was just integrated into master:
commit b959fbb87adb274b442bc6ab812e5a2ce92ca220
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Apr 5 16:11:12 2013 -0700

    exynos5: Re-factor I2C code
    This re-factors the Exynos5 I2C code to be simpler and use the
    new API, and updates users accordingly.
    - i2c_read() and i2c_write() functions updated to take bus number
      as an argument.
    - Get rid of the EEPROM_ADDR_OVERFLOW stuff in i2c_read() and
      i2c_write(). If a chip needs special handling we should take care
      of it elsewhere, not in every low-level i2c driver.
    - All the confusing bus config functions eliminated. No more
      i2c_set_early_config() or i2c_set_bus() or i2c_get_bus(). All this
      is handled automatically when the caller does a transaction and
      specifies the desired bus number.
    - i2c_probe() eliminated. We're not a command-line utility.
    - Let the compiler place static variables automatically. We don't need
      any of this fancy manual data placement.
    - Remove dead code while we're at it. This stuff was ported early on
      and much of it was left commented out in case we needed it. Some
      also includes nested macros which caused gcc to complain.
    - Clean up #includes (no more common.h, woohoo!), replace debug() with
    Change-Id: I8e1f974ea4c6c7db9f33b77bbc4fb16008ed0d2a
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/3044
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Tue Apr  9 04:11:42 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Apr 10 00:01:02 2013, giving +2
See http://review.coreboot.org/3044 for details.


More information about the coreboot-gerrit mailing list