[coreboot-gerrit] New patch to review for coreboot: 32ad472 exynos5250: add missing address-of operator in UART driver

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Mon Apr 8 02:51:38 CEST 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3038


commit 32ad472aa1b52549eae47a0f21746c8e41eff871
Author: David Hendricks <dhendrix at chromium.org>
Date:   Sun Apr 7 17:38:32 2013 -0700

    exynos5250: add missing address-of operator in UART driver
    This adds a missing address-of operator. This was a subtle bug that
    didn't seem to cause problems at first since the serial console
    appeared to work. However it caused an imprecise external abort which
    became apparent later on when aborts were unmasked in the kernel via
    the CPSR_A bit.
    (credit goes to Gabe Black for finding this)
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Change-Id: I80a33b147d92d559fa8fefbe7d5642235deb9aea
 src/cpu/samsung/exynos5250/uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/samsung/exynos5250/uart.c b/src/cpu/samsung/exynos5250/uart.c
index d23087a..75c5763 100644
--- a/src/cpu/samsung/exynos5250/uart.c
+++ b/src/cpu/samsung/exynos5250/uart.c
@@ -185,7 +185,7 @@ static void exynos5_uart_tx_byte(unsigned char data)
 	struct s5p_uart *uart = (struct s5p_uart *)base_port;
 	/* wait for room in the tx FIFO */
-	while ((readl(uart->ufstat) & TX_FIFO_FULL_MASK)) {
+	while ((readl(&uart->ufstat) & TX_FIFO_FULL_MASK)) {
 		if (exynos5_uart_err_check(1))

More information about the coreboot-gerrit mailing list