[coreboot-gerrit] New patch to review for coreboot: 5ea220f cbmem: Makefile: Fix typo: s, CPPFLAGS, CFLAGS,

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Apr 5 11:24:35 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3028


commit 5ea220f7056480a3415e548e2533d36cc18823a8
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Apr 5 11:12:12 2013 +0200

    cbmem: Makefile: Fix typo: s,CPPFLAGS,CFLAGS,
    Commit »cbmem compilation needs to use the hardened toolchain«
    (7c6b6bb5) [1] introduced `CPPFLAGS` but used `CFLAGS`, which gives
    the following build error, which was not spotted by Jenkins,
    because programs under `utils/` are not build tested.
        cbmem.c:36:34: fatal error: boot/coreboot_tables.h: Datei oder Verzeichnis nicht gefunden
        compilation terminated.
    As this is a C program, change `CPPFLAGS` to `CFLAGS`, causing the
    actual directories get passed to the compiler and the header file
    is found then.
    [1] http://review.coreboot.org/1791
    Change-Id: I254d76c7d98b6f920501407239566e9655b2ddeb
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 util/cbmem/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile
index bf74e08..e976d28 100644
--- a/util/cbmem/Makefile
+++ b/util/cbmem/Makefile
@@ -22,7 +22,7 @@ ROOT = ../../src
 CC     = $(CROSS_COMPILE)gcc
 CFLAGS ?= -O2
 CFLAGS += -Wall -Werror
-CPPFLAGS += -iquote $(ROOT)/include -iquote $(ROOT)/src/arch/x86
+CFLAGS += -iquote $(ROOT)/include -iquote $(ROOT)/src/arch/x86

More information about the coreboot-gerrit mailing list