[coreboot-gerrit] Patch merged into coreboot/master: 3402a7f inteltool: Cast to `intptr_t` instead of `uint64_t`

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit 3402a7fa7001e40035b6ae303b2e47b6281fef1c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Apr 1 18:26:58 2013 +0200

    inteltool: Cast to `intptr_t` instead of `uint64_t`
    
    When building inteltool under x86-32, the following warnings are
    shown.
    
        $ gcc --version
        gcc-4.7.real (Debian 4.7.2-15) 4.7.2
        Copyright (C) 2012 Free Software Foundation, Inc.
        This is free software; see the source for copying conditions.  There is NO
        warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
        $ make
        […]
        amb.c: In function ‘amb_read_config32’:
        amb.c:31:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:31:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config16’:
        amb.c:45:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:45:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config8’:
        amb.c:60:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:60:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        […]
    
    Nico Huber commented the following [1].
    
        I don't see those warnings because I build for x86-64. I guess
        they could be fixed by casting to `ptrdiff_t` (from stddef.h)
        instead of `uint64_t`.
    
    And indeed, using `ptrdiff_t` fixes the warning. But as Stefan
    Reinauer commented in [2], `intptr_t` is more appropriate as this
    is just a pointer and no pointer difference.
    
    So `intptr_t` is taken, which fixes these issues warned about too.
    
    These warnings were introduced in commit »inteltool: Add support for
    dumping AMB registers« (4b7b320f) [3].
    
    [1] http://review.coreboot.org/#/c/2996/1//COMMIT_MSG
    [2] http://review.coreboot.org/#/c/3002/1/util/inteltool/amb.c
    [3] http://review.coreboot.org/525
    
    Change-Id: I2ea1a31dc1e3db129e767d6a9e0433fd75a77d0f
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3002
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.huber at secunet.com>

Build-Tested: build bot (Jenkins) at Wed Apr  3 12:08:10 2013, giving +1
Reviewed-By: Nico Huber <nico.huber at secunet.com> at Thu Apr  4 14:24:25 2013, giving +2
See http://review.coreboot.org/3002 for details.

-gerrit